s4:dsdb/acl_read: return the nTSecurityDescriptor attr if the sd_flags control is...

Not returning the nTSecurityDescriptor causes a lot of problems.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>

diff --git a/source4/dsdb/samdb/ldb_modules/acl_read.c b/source4/dsdb/samdb/ldb_modules/acl_read.c
index 787e3ef5b95dd3805e04108a7efec2c6f9bf5351..9955451e7787416ae92e73091e25275e5b8cbc91 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/acl_read.c
+++ b/source4/dsdb/samdb/ldb_modules/acl_read.c
@@ -296,6 +296,7 @@ static int aclread_search(struct ldb_module *module, struct ldb_request *req)
        struct ldb_result *res;
        struct aclread_private *p;
        bool need_sd = false;
+       bool explicit_sd_flags = false;
        bool is_untrusted = ldb_req_is_untrusted(req);
        static const char * const _all_attrs[] = { "*", NULL };
        bool all_attrs = false;
@@ -383,9 +384,15 @@ static int aclread_search(struct ldb_module *module, struct ldb_request *req)
         * expensive so we'd better had the ntsecuritydescriptor to the list of
         * searched attribute and then remove it !
         */
-       ac->sd_flags = dsdb_request_sd_flags(ac->req, NULL);
+       ac->sd_flags = dsdb_request_sd_flags(ac->req, &explicit_sd_flags);
 
-       need_sd = !(ldb_attr_in_list(attrs, "nTSecurityDescriptor"));
+       if (ldb_attr_in_list(attrs, "nTSecurityDescriptor")) {
+               need_sd = false;
+       } else if (explicit_sd_flags && all_attrs) {
+               need_sd = false;
+       } else {
+               need_sd = true;
+       }
 
        if (!all_attrs) {
                if (!ldb_attr_in_list(attrs, "instanceType")) {