git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e87adf5
)
Revert "s3: remove unused Variable"
author
Jeremy Allison
<jra@samba.org>
Tue, 26 Jan 2010 01:06:54 +0000
(17:06 -0800)
committer
Jeremy Allison
<jra@samba.org>
Tue, 26 Jan 2010 01:06:54 +0000
(17:06 -0800)
This reverts commit
9536d94d5478b63fc05047964b40d8786a7246c4
.
Bjorn, your change removed the ndr_decoding of the dos attribute.
Not a good idea :-).
Jeremy.
source3/smbd/dosmode.c
patch
|
blob
|
history
diff --git
a/source3/smbd/dosmode.c
b/source3/smbd/dosmode.c
index bc39e02285718259a033b27425646d906eeb91b8..aaef09bc85cca8b5b78e7c400ff958d0b7d23dd2 100644
(file)
--- a/
source3/smbd/dosmode.c
+++ b/
source3/smbd/dosmode.c
@@
-226,6
+226,7
@@
static bool get_ea_dos_attribute(connection_struct *conn,
uint32 *pattr)
{
struct xattr_DOSATTRIB dosattrib;
+ enum ndr_err_code ndr_err;
DATA_BLOB blob;
ssize_t sizeret;
fstring attrstr;
@@
-260,6
+261,9
@@
static bool get_ea_dos_attribute(connection_struct *conn,
blob.data = (uint8_t *)attrstr;
blob.length = sizeret;
+ ndr_err = ndr_pull_struct_blob(&blob, talloc_tos(), NULL, &dosattrib,
+ (ndr_pull_flags_fn_t)ndr_pull_xattr_DOSATTRIB);
+
DEBUG(10,("get_ea_dos_attribute: %s attr = %s\n",
smb_fname_str_dbg(smb_fname), dosattrib.attrib_hex));