s4:rpcsrv:samr: improve a comment in compare_msgRid
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Mon, 8 Apr 2024 10:55:50 +0000 (22:55 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 23 Apr 2024 01:33:29 +0000 (01:33 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/rpc_server/samr/dcesrv_samr.c

index e50b9165d617becc72d0a67a701d0d51288d0d5a..dd767d936a696e399b6af6dbecd9373656a999ad 100644 (file)
@@ -1197,8 +1197,9 @@ static int compare_msgRid(struct ldb_message **m1, struct ldb_message **m2) {
        }
 
        /*
-        * Get and compare the rids, if we fail to extract a rid treat it as a
-        * missing SID and sort to the end of the list
+        * Get and compare the rids. If we fail to extract a rid (because
+        * there are no subauths) the msg goes to the end of the list, but
+        * before the NULL SIDs.
         */
        status = dom_sid_split_rid(NULL, sid1, NULL, &rid1);
        if (!NT_STATUS_IS_OK(status)) {