s3:smb2_ioctl: Fix Coverity ID 701771 Uninitialized scalar variable

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 21 19:27:44 CEST 2012 on sn-devel-104

diff --git a/source3/smbd/smb2_ioctl.c b/source3/smbd/smb2_ioctl.c
index b1a9e32f368c244c433e57ad07c8510e92191f1b..37acf11767c0ac2f882aba2e2464b1536103b386 100644 (file)
--- a/source3/smbd/smb2_ioctl.c
+++ b/source3/smbd/smb2_ioctl.c
@@ -417,6 +417,11 @@ static struct tevent_req *smbd_smb2_ioctl_send(TALLOC_CTX *mem_ctx,
                in_security_mode = SVAL(in_input.data, 0x14);
                in_max_dialect = SVAL(in_input.data, 0x16);
 
                in_security_mode = SVAL(in_input.data, 0x14);
                in_max_dialect = SVAL(in_input.data, 0x16);
 

+               status = GUID_from_ndr_blob(&in_guid_blob, &in_guid);
+               if (tevent_req_nterror(req, status)) {
+                       return tevent_req_post(req, ev);
+               }
+

                max_dialect = conn->smb2.client.dialects[conn->smb2.client.num_dialects-1];
                if (in_max_dialect != max_dialect) {
                        state->disconnect = true;
                max_dialect = conn->smb2.client.dialects[conn->smb2.client.num_dialects-1];
                if (in_max_dialect != max_dialect) {
                        state->disconnect = true;


@@ -494,6 +499,11 @@ static struct tevent_req *smbd_smb2_ioctl_send(TALLOC_CTX *mem_ctx,
                        return tevent_req_post(req, ev);
                }
 
                        return tevent_req_post(req, ev);
                }
 

+               status = GUID_from_ndr_blob(&in_guid_blob, &in_guid);
+               if (tevent_req_nterror(req, status)) {
+                       return tevent_req_post(req, ev);
+               }
+

                if (in_num_dialects != conn->smb2.client.num_dialects) {
                        state->disconnect = true;
                        tevent_req_nterror(req, NT_STATUS_ACCESS_DENIED);
                if (in_num_dialects != conn->smb2.client.num_dialects) {
                        state->disconnect = true;
                        tevent_req_nterror(req, NT_STATUS_ACCESS_DENIED);