ldb-samba:ldif_handlers: dn_link_comparison semi-sorts deleted objects

We were always returning -1 for a deleted object, which works for an
equality test, but not a relative comparison.

This sorts deleted DNs toward the end of the list -- except when both
DNs are deleted. What should happen there is yet to be determined.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/lib/ldb-samba/ldif_handlers.c b/lib/ldb-samba/ldif_handlers.c
index 492f42077bda986a5649b4def10045fdaee8669e..83199019ed3c1c112726c9acade7e7e8b87fc8a1 100644 (file)
--- a/lib/ldb-samba/ldif_handlers.c
+++ b/lib/ldb-samba/ldif_handlers.c
@@ -1161,13 +1161,15 @@ static int samba_ldb_dn_link_comparison(struct ldb_context *ldb, void *mem_ctx,
        struct ldb_dn *dn1 = NULL, *dn2 = NULL;
        int ret;
 
+       /*
+        * In a sort context, Deleted DNs get shifted to the end.
+        * They never match in an equality
+        */
        if (dsdb_dn_is_deleted_val(v1)) {
-               /* If the DN is deleted, then we can't search for it */
-               return -1;
+               return 1;
        }
 
        if (dsdb_dn_is_deleted_val(v2)) {
-               /* If the DN is deleted, then we can't search for it */
                return -1;
        }