lib:crypto: Remove redundant array zeroing
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 30 Nov 2023 03:20:02 +0000 (16:20 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 8 Dec 2023 02:28:33 +0000 (02:28 +0000)
The call to memset_s() was supposed to replace the use of
ZERO_ARRAY_LEN(), but somehow both lines have crept in.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/crypto/gnutls_sp800_108.c

index 65710657bae22547744e9ba670f0e585c051efc3..fb0aa03921329499b8a69d9b45fbeb9b4afec698 100644 (file)
@@ -224,7 +224,6 @@ out:
        if (!NT_STATUS_IS_OK(status)) {
                /* Hide the evidence. */
                memset_s(KO, KO_len, 0, KO_idx);
-               ZERO_ARRAY_LEN(KO, KO_idx);
        }
 
        return status;