s4/rpc_server/dnsserver: clang: fix Value stored to 'status' is never read

Fix the following warnings

source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1021: error: uninitvar: Uninitialized variable: answer_integer <--[cppcheck]
source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1723:4: warning: Value stored to 'status' is never read <--[clang]
                        status = dns_fill_records_array(tmp_ctx, NULL, DNS_TYPE_A,
                        ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
source4/rpc_server/dnsserver/dcerpc_dnsserver.c:1881:4: warning: Value stored to 'status' is never read <--[clang]
                        status = dns_fill_records_array(tmp_ctx, NULL, DNS_TYPE_A,

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
index 1bb46a58339a6343870cb1522124c24e651074f7..62a74127ecf467e4cb3707cd45dce8d236bc4b55 100644 (file)
--- a/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
+++ b/source4/rpc_server/dnsserver/dcerpc_dnsserver.c
@@ -1727,6 +1727,10 @@ static WERROR dnsserver_enumerate_root_records(struct dnsserver_state *dsstate,
                                                        NULL, NULL);
                        talloc_free(rname);
                        talloc_free(res);
+                       if (!W_ERROR_IS_OK(status)) {
+                               talloc_free(tmp_ctx);
+                               return status;
+                       }
                }
        }
 
@@ -1885,6 +1889,10 @@ static WERROR dnsserver_enumerate_records(struct dnsserver_state *dsstate,
                                                        NULL, NULL);
                        talloc_free(rname);
                        talloc_free(res);
+                       if (!W_ERROR_IS_OK(status)) {
+                               talloc_free(tmp_ctx);
+                               return status;
+                       }
                }
        }