s4-mailslot: fixed handling of random collision in temporary mailslot names

we could get occasional failures in the samba4.nbt.dgram test if we
happened to get a collision in the random mailslot names.

Thanks to Jeremy for spotting this! (his autobuild failed)

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/libcli/dgram/mailslot.c b/source4/libcli/dgram/mailslot.c
index 261946e458731adb2665c5e5c903823977884d29..38dd8fb41ebc02d0a89ce27d4581f59e438fc83d 100644 (file)
--- a/source4/libcli/dgram/mailslot.c
+++ b/source4/libcli/dgram/mailslot.c
@@ -129,7 +129,7 @@ struct dgram_mailslot_handler *dgram_mailslot_temp(struct nbt_dgram_socket *dgms
                if (name == NULL) return NULL;
                if (dgram_mailslot_find(dgmsock, name)) {
                        talloc_free(name);
-                       return NULL;
+                       continue;
                }
                dgmslot = dgram_mailslot_listen(dgmsock, name, handler, private_data);
                talloc_free(name);