Fix CID 1125634 Out-of-bounds write
authorVolker Lendecke <vl@samba.org>
Thu, 26 Mar 2015 12:06:26 +0000 (13:06 +0100)
committerMartin Schwenke <martin@meltin.net>
Wed, 24 Feb 2016 06:00:24 +0000 (17:00 +1100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(Imported from commit 93d4e801298d8ebb7261adbfc2bdb1a5fbe7115c)

tests/src/ctdb_takeover_tests.c

index 04b49e879b2da7d2e2978efcfa84a0a97468adbf..3c5015eca4d066e24486304f1890f19bf9593c7d 100644 (file)
@@ -431,7 +431,7 @@ static void ctdb_test_init(const char nodestates[],
        while (tok != NULL) {
                nodeflags[numnodes] = (uint32_t) strtol(tok, NULL, 0);
                numnodes++;
-               if (numnodes > CTDB_TEST_MAX_NODES) {
+               if (numnodes >= CTDB_TEST_MAX_NODES) {
                        DEBUG(DEBUG_ERR, ("ERROR: Exceeding CTDB_TEST_MAX_NODES: %d\n", CTDB_TEST_MAX_NODES));
                        exit(1);
                }