s4-libsmb: Do not set empty password for gensec

GENSEC expects NULL as no password. There are too many places which
set "" instead of NULL. We plan to pass down the cli_credentials
structure anyway so this workaround should be ok for now.

Signed-off-by: Andreas Schneider <asn@samba.org>

diff --git a/source3/libsmb/auth_generic.c b/source3/libsmb/auth_generic.c
index 59560d677bc2aba7710d236828de8902e8137e9c..4ccb7acc1687d4d1ee32c369735f02c8d83974dd 100644 (file)
--- a/source3/libsmb/auth_generic.c
+++ b/source3/libsmb/auth_generic.c
@@ -44,7 +44,9 @@ NTSTATUS auth_generic_set_domain(struct auth_generic_state *ans,
 NTSTATUS auth_generic_set_password(struct auth_generic_state *ans,
                                   const char *password)
 {
-       cli_credentials_set_password(ans->credentials, password, CRED_SPECIFIED);
+       if (password != NULL && password[0] != '\0') {
+               cli_credentials_set_password(ans->credentials, password, CRED_SPECIFIED);
+       }
        return NT_STATUS_OK;
 }