s3:libsmb: don't use gensec_ntlmssp_server_domain()
authorStefan Metzmacher <metze@samba.org>
Thu, 12 May 2016 15:16:28 +0000 (17:16 +0200)
committerStefan Metzmacher <metze@samba.org>
Mon, 18 Feb 2019 12:47:43 +0000 (13:47 +0100)
This is a layer violation and this information is not
when using kerberos.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
source3/libsmb/cliconnect.c

index 1d2a6b5fed6bd9fc8c9937ae72e50a04cd27ba05..f7acac39253eb364d55e1179d06be9ef7a324a95 100644 (file)
@@ -1242,7 +1242,6 @@ static void cli_session_setup_gensec_ready(struct tevent_req *req)
        struct cli_session_setup_gensec_state *state =
                tevent_req_data(req,
                struct cli_session_setup_gensec_state);
-       const char *server_domain = NULL;
        NTSTATUS status;
 
        if (state->blob_in.length != 0) {
@@ -1255,27 +1254,6 @@ static void cli_session_setup_gensec_ready(struct tevent_req *req)
                return;
        }
 
-       /*
-        * gensec_ntlmssp_server_domain() returns NULL
-        * if NTLMSSP is not used.
-        *
-        * We can remove this later
-        * and leave the server domain empty for SMB2 and above
-        * in future releases.
-        */
-       server_domain = gensec_ntlmssp_server_domain(
-                               state->auth_generic->gensec_security);
-
-       if (state->cli->server_domain[0] == '\0' && server_domain != NULL) {
-               TALLOC_FREE(state->cli->server_domain);
-               state->cli->server_domain = talloc_strdup(state->cli,
-                                       server_domain);
-               if (state->cli->server_domain == NULL) {
-                       tevent_req_nterror(req, NT_STATUS_NO_MEMORY);
-                       return;
-               }
-       }
-
        if (state->is_anonymous) {
                /*
                 * Windows server does not set the