git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
6848625
)
source3/libaddns: remove pointless check for resp->num_additionals != 1
author
Stefan Metzmacher
<metze@samba.org>
Fri, 9 Nov 2012 07:55:40 +0000
(08:55 +0100)
committer
Karolin Seeger
<kseeger@samba.org>
Fri, 14 Dec 2012 09:01:39 +0000
(10:01 +0100)
We never use resp->additionals, so there's no reason to check.
This fixes dns updates against BIND9 (used in a Samba4 domain).
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit
b59c5db5f74f56c0536635a41ae51c389109ceb5
)
(cherry picked from commit
4bb99f454cea8a0c37422f1e64cabe96543ca6e8
)
source3/libaddns/dnsgss.c
patch
|
blob
|
history
diff --git
a/source3/libaddns/dnsgss.c
b/source3/libaddns/dnsgss.c
index c9037417da954d99221e8e45dcfba19014774cf2..fe7c6ca536e56610dbc7d87cea0285e3f09de6a4 100644
(file)
--- a/
source3/libaddns/dnsgss.c
+++ b/
source3/libaddns/dnsgss.c
@@
-175,8
+175,7
@@
static DNS_ERROR dns_negotiate_gss_ctx_int( TALLOC_CTX *mem_ctx,
* TODO: Compare id and keyname
*/
* TODO: Compare id and keyname
*/
- if ((resp->num_additionals != 1) ||
- (resp->num_answers == 0) ||
+ if ((resp->num_answers == 0) ||
(resp->answers[0]->type != QTYPE_TKEY)) {
err = ERROR_DNS_INVALID_MESSAGE;
goto error;
(resp->answers[0]->type != QTYPE_TKEY)) {
err = ERROR_DNS_INVALID_MESSAGE;
goto error;