lkdtm/bugs: Improve warning message for compilers without counted_by support
authorNathan Chancellor <nathan@kernel.org>
Thu, 21 Mar 2024 20:18:17 +0000 (13:18 -0700)
committerKees Cook <keescook@chromium.org>
Fri, 22 Mar 2024 23:25:31 +0000 (16:25 -0700)
The current message for telling the user that their compiler does not
support the counted_by attribute in the FAM_BOUNDS test does not make
much sense either grammatically or semantically. Fix it to make it
correct in both aspects.

Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20240321-lkdtm-improve-lack-of-counted_by-msg-v1-1-0fbf7481a29c@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
drivers/misc/lkdtm/bugs.c

index b92767d6bdd24462c583c8f3d2dc7c09f08a4ad1..5178c02b21eba9c6898790cac69b878f3f562783 100644 (file)
@@ -417,7 +417,7 @@ static void lkdtm_FAM_BOUNDS(void)
        pr_err("FAIL: survived access of invalid flexible array member index!\n");
 
        if (!__has_attribute(__counted_by__))
-               pr_warn("This is expected since this %s was built a compiler supporting __counted_by\n",
+               pr_warn("This is expected since this %s was built with a compiler that does not support __counted_by\n",
                        lkdtm_kernel_info);
        else if (IS_ENABLED(CONFIG_UBSAN_BOUNDS))
                pr_expected_config(CONFIG_UBSAN_TRAP);