tests: Fix compiler warning that arrays might not be initialized

tests/test_echo_tcp_sendmsg_recvmsg_fd.c: In function 'test_tcp_sendmsg_recvmsg_fd_mixed':
tests/test_echo_tcp_sendmsg_recvmsg_fd.c:477:9: error: '<unknown>' may be used uninitialized [-Werror=maybe-uninitialized]
  477 |         test_tcp_sendmsg_recvmsg_fd_array(fd_array, num_fds);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tests/test_echo_tcp_sendmsg_recvmsg_fd.c:103:13: note: by argument 1 of type 'const int *' to 'test_tcp_sendmsg_recvmsg_fd_array' declared here
  103 | static void test_tcp_sendmsg_recvmsg_fd_array(const int *fds, size_t num_fds)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/tests/test_echo_tcp_sendmsg_recvmsg_fd.c b/tests/test_echo_tcp_sendmsg_recvmsg_fd.c
index 215d5ff40e59d4bdce4805d7189992322cc2aeb4..e6892e6aa2a3cd51aeda89f30595434f1745edcf 100644 (file)
--- a/tests/test_echo_tcp_sendmsg_recvmsg_fd.c
+++ b/tests/test_echo_tcp_sendmsg_recvmsg_fd.c
@@ -320,6 +320,9 @@ static void test_tcp_sendmsg_recvmsg_fd_different(size_t num_fds)
        int fd_array[num_fds];
        size_t idx;
 
+       assert_int_not_equal(num_fds, 0);
+       memset(fd_array, -1, sizeof(fd_array));
+
        for (idx = 0; idx < num_fds; idx++) {
                struct torture_address addr = {
                        .sa_socklen = sizeof(struct sockaddr_in),
@@ -388,10 +391,10 @@ static void test_tcp_sendmsg_recvmsg_fd_mixed(size_t num_fds)
        int close_array[num_fds];
        size_t idx;
 
-       for (idx = 0; idx < num_fds; idx++) {
-               fd_array[idx] = -1;
-               close_array[idx] = -1;
-       }
+       assert_int_not_equal(num_fds, 0);
+
+       memset(fd_array, -1, sizeof(fd_array));
+       memset(close_array, -1, sizeof(fd_array));
 
        /*
         * We send