s3: Fix Coverity ID 2232, REVERSE_INULL

No point checking for !cli after dereferencing it

diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
index ebbe849ac7bcf1414de602cbc6e3f2b4caa02f1a..0109bdae725432a426f5746fb19742a0e7b1ce55 100644 (file)
--- a/source3/rpc_client/cli_pipe.c
+++ b/source3/rpc_client/cli_pipe.c
@@ -3256,7 +3256,7 @@ NTSTATUS cli_get_session_key(TALLOC_CTX *mem_ctx,
                             struct rpc_pipe_client *cli,
                             DATA_BLOB *session_key)
 {
-       struct pipe_auth_data *a = cli->auth;
+       struct pipe_auth_data *a;
        struct schannel_state *schannel_auth;
        struct auth_ntlmssp_state *ntlmssp_ctx;
        struct spnego_context *spnego_ctx;
@@ -3268,7 +3268,9 @@ NTSTATUS cli_get_session_key(TALLOC_CTX *mem_ctx,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (!cli->auth) {
+       a = cli->auth;
+
+       if (a == NULL) {
                return NT_STATUS_INVALID_PARAMETER;
        }