Michael Adam [Thu, 31 Mar 2011 14:12:02 +0000 (16:12 +0200)]
s3:configure: allow building without SCHEDULE_FOR_DELETION with --enable-old-ctdb
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Mar 31 18:55:38 CEST 2011 on sn-devel-104
Michael Adam [Thu, 31 Mar 2011 14:06:36 +0000 (16:06 +0200)]
s3:configure: introduce "--enable-old-ctdb" to enable enforcing build against old ctdb
Michael Adam [Thu, 31 Mar 2011 13:39:41 +0000 (15:39 +0200)]
s3:configure: add check for new CTDB_CONTROL_SCHEDULE_FOR_DELETION
Michael Adam [Thu, 31 Mar 2011 13:23:28 +0000 (15:23 +0200)]
s3:configure: rework logic of ctdb/clustering checks
Michael Adam [Thu, 31 Mar 2011 12:17:44 +0000 (14:17 +0200)]
s3:configure: remove unused variable CTDB_CFLAGS
Michael Adam [Thu, 31 Mar 2011 11:45:21 +0000 (13:45 +0200)]
s3:configure: fix a comment.
Michael Adam [Wed, 22 Dec 2010 13:16:07 +0000 (14:16 +0100)]
s3:dbwrap_ctdb: in ctdb_delete, send a SCHEDULE_FOR_DELETION control to local ctdbd
This way, the record will be scheduled for fast vacuuming.
This is sent with the NOREPLY flag, so ctd should not sent
a reply packet and samba does not expect one. Hence, it
is not important for the success of the db_ctdb_delete command
whether or not the ctdbd we are running against supports the
SCHEDULE_FOR_DELETION control.
Michael Adam [Tue, 8 Mar 2011 15:26:34 +0000 (16:26 +0100)]
s3:ctdb: pass the ctdb control flags to the ctdb daemon when sending the control
The only flag that is currently used is the NOREPLY flag to indicate that
the client expects no reply packet. This needs to get passed down to the
ctdb daemon so that it really does not send a reply.
Michael Adam [Thu, 23 Dec 2010 15:46:24 +0000 (16:46 +0100)]
s3:ctdb: samba can now handle the NOREPLY flag
Revert "samba3 can't handle NOREPLY yet"
This reverts commit
9bf211db6d7d6ef6e59508de69d6d8dfe5bae059.
Michael Adam [Thu, 23 Dec 2010 15:43:55 +0000 (16:43 +0100)]
s3:ctdb: correctly handle cstatus if CTDB_CTRL_FLAG_NOREPLY is set.
Sumit Bose [Thu, 31 Mar 2011 12:09:45 +0000 (14:09 +0200)]
s3-net: Do not use uninitialized value
s3-net: Do not use uninitialized value
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Mar 31 18:09:57 CEST 2011 on sn-devel-104
Andreas Schneider [Wed, 30 Mar 2011 09:08:31 +0000 (11:08 +0200)]
s3-winbindd: Use the correct enums for samr_QueryDomainInfo.
Andrew Bartlett [Thu, 31 Mar 2011 05:44:24 +0000 (16:44 +1100)]
lib/util/charset Add tests for strcasecmp_m(), talloc_strupper() et al
This adds tests for:
strncasecmp_m
strcasecmp_m
strupper_talloc_n
strlower_talloc
strhaslower
strhasupper
The tests can certainly be improved with pre-calculated upper and
lower case text, but this at least puts them though their paces.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Mar 31 14:24:22 CEST 2011 on sn-devel-104
Andrew Tridgell [Thu, 31 Mar 2011 04:16:51 +0000 (15:16 +1100)]
s4-dsdb: cope with failed searches in the linked attributes callback
This fixes a bug where we try to add an empty backlink because the
search for the forward link failed.
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 31 13:37:36 CEST 2011 on sn-devel-104
Andrew Tridgell [Wed, 30 Mar 2011 06:30:08 +0000 (17:30 +1100)]
s3-torture: a very simple test for convert_string_error()
this is a very simple test based on the example volker gave in
1e50f9a5. A more sophisticated test will also be worthwhile, but this
at least gives us a basic test while changes are being made
Volker Lendecke [Thu, 31 Mar 2011 10:02:26 +0000 (12:02 +0200)]
s3: Fix a typo
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 31 12:50:53 CEST 2011 on sn-devel-104
Volker Lendecke [Thu, 31 Mar 2011 06:25:32 +0000 (08:25 +0200)]
charconv: Use talloc_tos() in the S3 build
In S3 we put a talloc_pool on top of the stack so that an allocation from
talloc_tos() normally is just a pointer increment.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 31 09:14:01 CEST 2011 on sn-devel-104
Jeremy Allison [Thu, 31 Mar 2011 02:27:29 +0000 (19:27 -0700)]
Arg. I hate the "if (xxx) return foo" all on one line style of code.
Fix the talloc leaks I introduced by not spotting these returns.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 31 05:19:34 CEST 2011 on sn-devel-104
Jeremy Allison [Thu, 31 Mar 2011 01:13:05 +0000 (18:13 -0700)]
Don't burn 2k of stack on every iconv, use the heap when it's a slow call.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 31 04:09:09 CEST 2011 on sn-devel-104
Jeremy Allison [Thu, 31 Mar 2011 01:00:09 +0000 (18:00 -0700)]
Fix bug #7996 - sgid bit lost on folder rename.
Refuse to set dos attributes into unix mode bits on such a
folder.
Holger Hetterich [Tue, 29 Mar 2011 20:16:10 +0000 (22:16 +0200)]
SMBTA: make vfs_smb_traffic_analyzer aware of the sendfile and recvfile functionality and store the results as common read/write results.
Andrew Bartlett [Wed, 30 Mar 2011 23:32:52 +0000 (10:32 +1100)]
lib/util/charset smb_panic() on incorrect use of strlen_m_ext
This may save a developer some time in the future.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Mar 31 02:40:31 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 30 Mar 2011 23:28:36 +0000 (10:28 +1100)]
lib/util/charset Add tests for strlen_m_ext() and convert_string_talloc()
This convers a few more cases for convert_string_talloc() and
introduces tests for strlen_m_ext() across complex multibyte strings.
Andrew Bartlett
Andrew Bartlett [Wed, 30 Mar 2011 23:27:41 +0000 (10:27 +1100)]
lib/util/charset Add wrapper to allow testing of strlen_m_ext()
This allows test routines to force in particular character sets, and
not rely on the smb.conf.
Andrew Bartlett
Andrew Bartlett [Wed, 30 Mar 2011 23:26:08 +0000 (10:26 +1100)]
lib/util/charset correct calculation of UTF8 character sizes
Characters between 0x800 0x0FFFF are 3 bytes long.
Andrew Bartlett
Günther Deschner [Wed, 30 Mar 2011 22:08:57 +0000 (00:08 +0200)]
s3-samr: make getgrgid() failure a little more visible in _samr_CreateDomAlias().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 31 01:00:42 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 22:08:19 +0000 (00:08 +0200)]
s3-idmap: fix the build of idmap_hash on FreeBSD.
Guenther
Günther Deschner [Wed, 30 Mar 2011 21:47:34 +0000 (23:47 +0200)]
s3-libndr: add ../librpc/ndr/libndr.h include in some places.
Guenther
Günther Deschner [Wed, 30 Mar 2011 21:21:42 +0000 (23:21 +0200)]
s3-rpcclient: include rpc_client/cli_pipe.h globally in rpcclient.h
Guenther
Günther Deschner [Wed, 30 Mar 2011 21:17:25 +0000 (23:17 +0200)]
rep_parse_prs: remove some dead, unused code.
Guenther
Jeremy Allison [Wed, 30 Mar 2011 20:08:31 +0000 (13:08 -0700)]
Fix convert_string() to take a *converted_size arg. and return a bool.
Makes these interfaces much harder to misuse and easier to ensure error
checking.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 30 23:59:37 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 20:24:42 +0000 (22:24 +0200)]
s3-build: make it a little easier to build smbtorture4.
Only configure with --enable-socket-wrapper --enable-nss-wrapper
--enable-uid-wrapper, not --enable-developer which turns on at least one -Werror
switch.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 23:12:42 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 20:24:18 +0000 (22:24 +0200)]
s3-vfs: try to fix build of aio_fork module.
Guenther
Jeremy Allison [Wed, 30 Mar 2011 17:27:04 +0000 (10:27 -0700)]
Change convert_string_internal() and convert_string_error() to bool return.
Move closer to makeing all convert_string_XXX functions return bool.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 30 20:58:10 CEST 2011 on sn-devel-104
Jeremy Allison [Wed, 30 Mar 2011 17:13:01 +0000 (10:13 -0700)]
Fix the nstring calls to use the correct sizes.
Jeremy Allison [Wed, 30 Mar 2011 16:58:22 +0000 (09:58 -0700)]
This doesn't look like it has anything to do with character set conversion, but it does :-).
Turns out one of the *really* significant differences between
convert_string() in source4 and source3, is that the one in
source3 will return 0 for byte length converted when called
with dest_len = 0 whereas the one in source4 returns (size_t)-1
and sets errno to E2BIG.
Allow the ndr_string code to cope with the (arguably correct)
way that the source4 implementation works. This code only gets
excercised in the print spooler tests, which aren't run in source4,
which is why this bug has lasted for so long.
You don't want to know how long it took me to find this :-).
Jeremy.
Volker Lendecke [Wed, 30 Mar 2011 14:38:31 +0000 (16:38 +0200)]
s3: Fix g_lock_lock after the select/poll conversion
Without clustering we don't have an fd to listen on, and sys_poll
needs one element of space
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 18:36:50 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 14:18:38 +0000 (16:18 +0200)]
s3-smbd: try to fix the irix build.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 17:17:58 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 13:14:05 +0000 (15:14 +0200)]
s3-vfs acl modules: more non-linux build fixes.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 16:00:02 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 13:09:10 +0000 (15:09 +0200)]
s3-passdb: move LOOKUP_NAME_ flags to passdb where they belong to.
Guenther
Günther Deschner [Wed, 30 Mar 2011 12:49:37 +0000 (14:49 +0200)]
s3-passdb: move some passdb defines to passdb.h
Guenther
Günther Deschner [Wed, 30 Mar 2011 12:48:18 +0000 (14:48 +0200)]
s3-proto: pure cosmetics, remove some generated comments.
Guenther
Günther Deschner [Wed, 30 Mar 2011 12:03:13 +0000 (14:03 +0200)]
s3-winbind: try to fix the build on hosts w/o winbind support.
Guenther
Günther Deschner [Wed, 30 Mar 2011 11:46:59 +0000 (13:46 +0200)]
s3-vfs_solarisacl: try to fix the solaris build.
Guenther
Volker Lendecke [Wed, 30 Mar 2011 11:19:46 +0000 (13:19 +0200)]
s3: Use cli_ntcreate to when listing snapshots
This works for directories as well
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 14:37:02 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 10:39:36 +0000 (12:39 +0200)]
s3: Fix Coverity ID 2041, "UNUSED_VALUE"
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 13:49:35 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 30 Mar 2011 06:49:30 +0000 (17:49 +1100)]
lib/util/charset Add tests for convert_string_talloc_handle()
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 30 13:02:47 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 30 Mar 2011 06:49:01 +0000 (17:49 +1100)]
lib/util Move base64 functions into lib/util/base64.c
Andrew Bartlett
Andrew Bartlett [Tue, 29 Mar 2011 02:21:52 +0000 (13:21 +1100)]
s3:lib make lazy_initialize_conv() static
Andrew Bartlett [Mon, 28 Mar 2011 22:45:22 +0000 (09:45 +1100)]
lib/util/charset Remove pointless static bool initialised
Günther Deschner [Wed, 30 Mar 2011 08:50:10 +0000 (10:50 +0200)]
s3: try to fix the build on some non-linux buildfarm machines.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 11:39:31 CEST 2011 on sn-devel-104
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2217: RESOURCE_LEAK
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 10:45:44 CEST 2011 on sn-devel-104
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2220: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2221: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2222: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 05:04:47 +0000 (07:04 +0200)]
s3: Fix Coverity ID 2223: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 04:57:05 +0000 (06:57 +0200)]
s3: Fix Coverity ID 2236: REVERSE_INULL
We have already dereferenced "b", and the other calls in this loop can only
have worked with a valid handle
Volker Lendecke [Wed, 30 Mar 2011 04:41:18 +0000 (06:41 +0200)]
s3: Fix Coverity ID 2332: MISSING_BREAK
Volker Lendecke [Wed, 30 Mar 2011 04:53:15 +0000 (06:53 +0200)]
s3: Fix Coverity ID 2237: REVERSE_INULL
Volker Lendecke [Wed, 30 Mar 2011 04:51:40 +0000 (06:51 +0200)]
tdb: Fix Coverity ID 2238: SECURE_CODING
Volker Lendecke [Wed, 30 Mar 2011 04:45:04 +0000 (06:45 +0200)]
s3: Fix Coverity ID 2304: FORWARD_NULL
Matthias Dieter Wallnöfer [Sun, 27 Mar 2011 20:14:56 +0000 (22:14 +0200)]
s4:lib/policy/gp_ldap.c - make more use of LDB result constants
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Mar 30 09:33:38 CEST 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 25 Mar 2011 19:03:42 +0000 (20:03 +0100)]
s4:lib/registry/registry.h - align a copyright line in header comment
Matthias Dieter Wallnöfer [Thu, 24 Mar 2011 08:41:19 +0000 (09:41 +0100)]
talloc - improve doxygen comment of "talloc_move"
Express better that this should be a pointer of a pointer.
Reviewed-by: Tridge
Matthias Dieter Wallnöfer [Thu, 24 Mar 2011 09:28:10 +0000 (10:28 +0100)]
s4:smb_server/smb/trans2.c - "talloc_move" isn't strictly necessary here
Since the "set" will be free'd afterwards "talloc_steal" is enough.
Reviewed-by: Tridge
Günther Deschner [Mon, 28 Mar 2011 10:27:21 +0000 (12:27 +0200)]
s3-ctdb_wrap: remove unused variable from db_ctdb_fetch_persistent().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 02:00:50 CEST 2011 on sn-devel-104
Günther Deschner [Fri, 25 Mar 2011 13:12:59 +0000 (14:12 +0100)]
s3-rpc_server: move access check functions out of samr server.
Guenther
Günther Deschner [Fri, 25 Mar 2011 12:42:42 +0000 (13:42 +0100)]
s3: only include ntioctl.h where needed.
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:56:52 +0000 (11:56 +0100)]
s3: only include lib/privileges.h where needed.
This finally removes the global lsa.h inclusion.
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:56:10 +0000 (11:56 +0100)]
s3: include ../librpc/gen_ndr/lsa.h where needed.
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:40:00 +0000 (11:40 +0100)]
s3-passdb: move lsa_dom_info and lsa_name_info out of smb.h into passdb.
Guenther
Günther Deschner [Thu, 24 Mar 2011 21:33:07 +0000 (22:33 +0100)]
s3-includes: only include ntdomain.h where needed.
Guenther
Günther Deschner [Thu, 24 Mar 2011 21:32:17 +0000 (22:32 +0100)]
pidl: add an include for "ntdomain.h" for s3 server stubs.
Guenther
Günther Deschner [Thu, 24 Mar 2011 14:56:32 +0000 (15:56 +0100)]
s3-messages: make ndr_messaging.h part of messages.h.
Guenther
Günther Deschner [Thu, 24 Mar 2011 14:31:06 +0000 (15:31 +0100)]
s3-messages: only include messages.h where needed.
Guenther
Günther Deschner [Thu, 24 Mar 2011 13:16:28 +0000 (14:16 +0100)]
s3-prototyes: user_in_netgroup and user_in_list moved to auth, out of smbd.
Guenther
Günther Deschner [Fri, 25 Mar 2011 01:28:17 +0000 (02:28 +0100)]
s3-includes: finally remove global include of auth.h.
Guenther
Günther Deschner [Thu, 24 Mar 2011 13:15:54 +0000 (14:15 +0100)]
s3-auth: vfs modules need auth.h
Guenther
Günther Deschner [Thu, 24 Mar 2011 13:12:42 +0000 (14:12 +0100)]
s3-auth: printing needs auth.h
Guenther
Günther Deschner [Thu, 24 Mar 2011 12:46:20 +0000 (13:46 +0100)]
s3-auth: smbd needs auth.h
Guenther
Günther Deschner [Thu, 24 Mar 2011 11:08:15 +0000 (12:08 +0100)]
s3-auth: rpc_server needs auth.h
Guenther
Günther Deschner [Fri, 25 Mar 2011 01:28:05 +0000 (02:28 +0100)]
s3-auth: use auth.h where needed.
Guenther
Günther Deschner [Fri, 25 Mar 2011 01:27:24 +0000 (02:27 +0100)]
s3-auth: move auth prototypes to auth/proto.h.
Guenther
Günther Deschner [Wed, 23 Mar 2011 13:18:59 +0000 (14:18 +0100)]
s3-libsmb: put namequery headers to nmblib.h
We might find a better name for it and merge other namequery related things as
well here...
Guenther
Günther Deschner [Wed, 23 Mar 2011 11:43:17 +0000 (12:43 +0100)]
s3-locking: move locking prototypes out of proto.h.
Will later become part of locking.h
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:15:55 +0000 (11:15 +0100)]
s3: finally remove global include of smbd prototypes.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:49:33 +0000 (23:49 +0100)]
s3: rpc_server needs parts of smbd.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:49:17 +0000 (23:49 +0100)]
s3: printing needs parts of smbd.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:49:03 +0000 (23:49 +0100)]
s3: auth also needs parts of smbd.
Guenther
Günther Deschner [Tue, 22 Mar 2011 21:34:22 +0000 (22:34 +0100)]
s3-vfs: include smbd/smbd.h in vfs modules.
Guenther
Günther Deschner [Tue, 22 Mar 2011 15:57:01 +0000 (16:57 +0100)]
s3: include smbd/smbd.h where needed.
Guenther
Günther Deschner [Fri, 18 Mar 2011 23:47:12 +0000 (00:47 +0100)]
s3-smbd: add smbd.h and move smbd prototypes to smbd/proto.h.
Guenther
Günther Deschner [Tue, 22 Mar 2011 20:45:44 +0000 (21:45 +0100)]
s3: move filename_util.c out of source3/smbd to source3/lib.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:58:21 +0000 (23:58 +0100)]
s3-build: only include intl protos where needed.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:32:56 +0000 (23:32 +0100)]
s3-passdb: finally stop including passdb.h globaly.
Guenther
Günther Deschner [Tue, 22 Mar 2011 15:50:02 +0000 (16:50 +0100)]
s3-passdb: use passdb headers where needed.
Guenther
Günther Deschner [Wed, 23 Mar 2011 13:57:08 +0000 (14:57 +0100)]
s3-passdb: move util_builtin.c out of passdb.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:23:17 +0000 (23:23 +0100)]
s3-passdb: move util_unixsids.c out of passdb.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:20:49 +0000 (23:20 +0100)]
s3-passdb: move util_wellknown.c out of passdb.
Guenther
Günther Deschner [Tue, 22 Mar 2011 16:43:39 +0000 (17:43 +0100)]
s3-winbindd: copy acct_info to wb_acct_info so we dont need passdb for it.
Guenther