s3/lib/netapi: Fix 'Possible null pointer dereference' warning
authorNoel Power <noel.power@suse.com>
Tue, 21 May 2019 11:00:42 +0000 (11:00 +0000)
committerNoel Power <npower@samba.org>
Wed, 29 May 2019 10:10:23 +0000 (10:10 +0000)
source3/lib/netapi/localgroup.c:1103: warning: nullPointer: Possible null pointer dereference: r <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/lib/netapi/localgroup.c

index e0200a9ddd13e0249e92eb0a2ae20494c4b795ab..f3667987b1aed42c0cbc81dc968c3a756b74a935 100644 (file)
@@ -1100,7 +1100,7 @@ static WERROR NetLocalGroupModifyMembers_r(struct libnetapi_ctx *ctx,
                r = (struct NetLocalGroupAddMembers *)set;
        }
 
-       if (!r->in.group_name) {
+       if (r==NULL || r->in.group_name == NULL) {
                return WERR_INVALID_PARAMETER;
        }