metze/samba/wip.git
4 years agoRevert "lib/compression/lzxpress.c..." master3-credits
Stefan Metzmacher [Fri, 5 Jul 2019 15:32:01 +0000 (17:32 +0200)]
Revert "lib/compression/lzxpress.c..."

This reverts commit 7a2922b183f102a8d378f3fda3844f1ca247d0cf.

4 years agolib/compression/lzxpress.c...
Stefan Metzmacher [Fri, 5 Jul 2019 15:31:48 +0000 (17:31 +0200)]
lib/compression/lzxpress.c...

4 years agoRevert "avoid SMB_ASSERT(!req->request_counters_updated); on re-dispatched requests"
Stefan Metzmacher [Thu, 4 Jul 2019 13:02:51 +0000 (15:02 +0200)]
Revert "avoid SMB_ASSERT(!req->request_counters_updated); on re-dispatched requests"

This reverts commit d5f6579317977618ecb215e709861ff510709ae9.

4 years agoavoid SMB_ASSERT(!req->request_counters_updated); on re-dispatched requests
Stefan Metzmacher [Fri, 13 Jul 2018 14:01:26 +0000 (16:01 +0200)]
avoid SMB_ASSERT(!req->request_counters_updated); on re-dispatched requests

4 years agoDEBUG python/samba/netcmd/fsmo.py
Stefan Metzmacher [Tue, 28 May 2019 12:54:45 +0000 (14:54 +0200)]
DEBUG python/samba/netcmd/fsmo.py

4 years agoDEBUG python/samba/netcmd/fsmo.py
Stefan Metzmacher [Tue, 28 May 2019 12:55:58 +0000 (14:55 +0200)]
DEBUG python/samba/netcmd/fsmo.py

4 years agoDEBUG source4/torture/drs/python/fsmo.py
Stefan Metzmacher [Tue, 28 May 2019 12:52:14 +0000 (14:52 +0200)]
DEBUG source4/torture/drs/python/fsmo.py

4 years agoDEBUG source4/torture/drs/python/fsmo.py
Stefan Metzmacher [Tue, 28 May 2019 12:57:37 +0000 (14:57 +0200)]
DEBUG source4/torture/drs/python/fsmo.py

4 years agoRevert "debug sddl"
Stefan Metzmacher [Fri, 1 Mar 2019 15:46:26 +0000 (16:46 +0100)]
Revert "debug sddl"

This reverts commit 43233a91f171bdc214bc688f6d4129048b06a12f.

4 years agodebug sddl
Stefan Metzmacher [Tue, 29 Jan 2019 13:57:18 +0000 (14:57 +0100)]
debug sddl

4 years agoRevert "smbXsrv_open_global add resilient/persistent"
Stefan Metzmacher [Sat, 26 Jan 2019 12:54:19 +0000 (13:54 +0100)]
Revert "smbXsrv_open_global add resilient/persistent"

This reverts commit 7668aaf5665e066a42113c628c0d7f6442d5a360.

4 years agoRevert "TODO later? smbXsrv_open_close_all"
Stefan Metzmacher [Mon, 18 Jun 2012 11:32:29 +0000 (13:32 +0200)]
Revert "TODO later? smbXsrv_open_close_all"

This reverts commit be146b939400dda6d2ec5b77d9f6224ce6363927.

4 years agoTODO later? smbXsrv_open_close_all
Stefan Metzmacher [Mon, 18 Jun 2012 11:27:19 +0000 (13:27 +0200)]
TODO later? smbXsrv_open_close_all

4 years agosmbXsrv_open_global add resilient/persistent
Stefan Metzmacher [Fri, 29 Jun 2012 11:38:19 +0000 (13:38 +0200)]
smbXsrv_open_global add resilient/persistent

4 years agoRevert "source4/torture/smb2/util.c ignore change time"
Stefan Metzmacher [Tue, 12 Feb 2019 08:27:35 +0000 (09:27 +0100)]
Revert "source4/torture/smb2/util.c ignore change time"

This reverts commit 61feeb514ba4b0eed6bad804a1fa34274e94f5fc.

4 years agosource4/torture/smb2/util.c ignore change time
Stefan Metzmacher [Wed, 16 Jan 2019 12:13:54 +0000 (13:13 +0100)]
source4/torture/smb2/util.c ignore change time

4 years agoRevert "works on all."
Stefan Metzmacher [Fri, 15 Feb 2019 15:59:40 +0000 (16:59 +0100)]
Revert "works on all."

This reverts commit b00999116c493fb8fc0d65367c3ab4453a3086ce.

4 years agoworks on all.
Stefan Metzmacher [Wed, 16 Jan 2019 16:01:12 +0000 (17:01 +0100)]
works on all.

4 years agoRevert "HACK only smb2.notify.valid-req"
Stefan Metzmacher [Wed, 13 Feb 2019 10:16:26 +0000 (11:16 +0100)]
Revert "HACK only smb2.notify.valid-req"

This reverts commit 1defbdb7233f5df3522f87c23c5bfd451b4b3de5.

4 years agoRevert "pass w2016 and make test"
Stefan Metzmacher [Wed, 13 Feb 2019 10:16:11 +0000 (11:16 +0100)]
Revert "pass w2016 and make test"

This reverts commit a6dc13f479d51e8dabafa4613f8b7eddeca5495e.

4 years agoRevert "pass samba"
Stefan Metzmacher [Wed, 13 Feb 2019 10:16:08 +0000 (11:16 +0100)]
Revert "pass samba"

This reverts commit 8d954f13d3c988d0f9b805421593295e0f995441.

4 years agopass samba
Stefan Metzmacher [Wed, 13 Feb 2019 10:15:20 +0000 (11:15 +0100)]
pass samba

4 years agopass w2016 and make test
Stefan Metzmacher [Tue, 12 Feb 2019 16:10:41 +0000 (17:10 +0100)]
pass w2016 and make test

4 years agoHACK only smb2.notify.valid-req
Stefan Metzmacher [Wed, 16 Jan 2019 11:32:44 +0000 (12:32 +0100)]
HACK only smb2.notify.valid-req

4 years agoDEBUG offload copy/chunk
Stefan Metzmacher [Wed, 27 Mar 2019 11:41:40 +0000 (12:41 +0100)]
DEBUG offload copy/chunk

4 years agotmp source4/torture/smb2/ioctl.c
Stefan Metzmacher [Thu, 21 Mar 2019 10:07:56 +0000 (11:07 +0100)]
tmp source4/torture/smb2/ioctl.c

4 years agoRevert "HACK source4/torture/smb2/getinfo.c"
Stefan Metzmacher [Thu, 25 Apr 2019 15:31:08 +0000 (17:31 +0200)]
Revert "HACK source4/torture/smb2/getinfo.c"

This reverts commit d74b21c3907c6aae796c04f0338b29bf91c7cdc1.

4 years agoHACK source4/torture/smb2/getinfo.c
Stefan Metzmacher [Thu, 25 Apr 2019 15:30:59 +0000 (17:30 +0200)]
HACK source4/torture/smb2/getinfo.c

4 years agoRevert "hash_domain_sid UINT32_MAX"
Stefan Metzmacher [Thu, 21 Mar 2019 15:36:09 +0000 (16:36 +0100)]
Revert "hash_domain_sid UINT32_MAX"

This reverts commit 054bc9fcc94f30344ec2c662eb031dde275ffbb5.

4 years agohash_domain_sid UINT32_MAX
Stefan Metzmacher [Thu, 21 Mar 2019 15:35:58 +0000 (16:35 +0100)]
hash_domain_sid UINT32_MAX

4 years agoads_change_trust_account_password
Stefan Metzmacher [Wed, 17 Apr 2019 16:18:00 +0000 (18:18 +0200)]
ads_change_trust_account_password

4 years agoidmap_hash: provide ID_TYPE_BOTH mappings
Stefan Metzmacher [Thu, 21 Mar 2019 15:38:35 +0000 (16:38 +0100)]
idmap_hash: provide ID_TYPE_BOTH mappings

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoidmap_hash: remember new domain sids in idmap_hash_sid_to_id()
Stefan Metzmacher [Thu, 21 Mar 2019 15:54:31 +0000 (16:54 +0100)]
idmap_hash: remember new domain sids in idmap_hash_sid_to_id()

This is similar to the checks in idmap_autorid_sid_to_id()
to check if a new mapping should be created.

This change means that idmap_hash_id_to_sid() can return mappings
for new domains learned in idmap_hash_sid_to_id().

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoidmap_hash: split out a idmap_hash_sid_to_id() helper function
Stefan Metzmacher [Thu, 21 Mar 2019 13:05:13 +0000 (14:05 +0100)]
idmap_hash: split out a idmap_hash_sid_to_id() helper function

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoidmap_hash: split out a idmap_hash_id_to_sid() helper function
Stefan Metzmacher [Thu, 21 Mar 2019 13:05:13 +0000 (14:05 +0100)]
idmap_hash: split out a idmap_hash_id_to_sid() helper function

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoidmap_hash: mirror the NT_STATUS_NONE_MAPPED/STATUS_SOME_UNMAPPED logic from idmap_au...
Stefan Metzmacher [Thu, 21 Mar 2019 13:00:16 +0000 (14:00 +0100)]
idmap_hash: mirror the NT_STATUS_NONE_MAPPED/STATUS_SOME_UNMAPPED logic from idmap_autorid

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoidmap_hash: we don't need to call idmap_hash_initialize() over and over again
Stefan Metzmacher [Thu, 21 Mar 2019 09:54:49 +0000 (10:54 +0100)]
idmap_hash: we don't need to call idmap_hash_initialize() over and over again

It's always the first function that's called from idmap_methods.

This also demonstrates that we currently always return NT_STATUS_OK,
even if we haven't mapped all map entries.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoidmap_hash: remove unused error checks
Stefan Metzmacher [Thu, 21 Mar 2019 12:54:10 +0000 (13:54 +0100)]
idmap_hash: remove unused error checks

id_map_ptrs_init() is used in the callers in order to
set everything up as expected.

Other backends also just trust the caller.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoidmap_hash: fix comments about the algorithm
Stefan Metzmacher [Thu, 21 Mar 2019 12:37:16 +0000 (13:37 +0100)]
idmap_hash: fix comments about the algorithm

Only only support ~ 50k users per domain.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agowinbindd/idmap: apply const to struct nss_info_methods pointers
Stefan Metzmacher [Thu, 21 Mar 2019 11:30:37 +0000 (12:30 +0100)]
winbindd/idmap: apply const to struct nss_info_methods pointers

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agowinbindd/idmap: apply const to struct idmap_methods pointers
Stefan Metzmacher [Thu, 21 Mar 2019 11:30:37 +0000 (12:30 +0100)]
winbindd/idmap: apply const to struct idmap_methods pointers

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agotest_idmap_tdb_common: correctly initialize the idmap domain with an init function
Stefan Metzmacher [Thu, 21 Mar 2019 11:29:00 +0000 (12:29 +0100)]
test_idmap_tdb_common: correctly initialize the idmap domain with an init function

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agoRevert "HACK debug replay/channel_sequence"
Stefan Metzmacher [Sat, 22 Sep 2012 19:52:13 +0000 (21:52 +0200)]
Revert "HACK debug replay/channel_sequence"

This reverts commit 46ce191a9bf9321251ea601a9b3ba7b48c5d5ccb.

4 years agoRevert "HACK disconnect after 2 writes"
Stefan Metzmacher [Thu, 26 Jul 2012 06:23:33 +0000 (08:23 +0200)]
Revert "HACK disconnect after 2 writes"

This reverts commit eaa7023f865be73483a99ff203d1dbfb3e180ef9.

4 years agoHACK disconnect after 2 writes
Stefan Metzmacher [Thu, 26 Jul 2012 06:23:10 +0000 (08:23 +0200)]
HACK disconnect after 2 writes

4 years agoHACK debug replay/channel_sequence
Stefan Metzmacher [Thu, 26 Jul 2012 06:22:01 +0000 (08:22 +0200)]
HACK debug replay/channel_sequence

4 years agoRevert "HACK FSCTL_LMR_REQ_RESILIENCY..."
Stefan Metzmacher [Wed, 2 Oct 2019 13:53:09 +0000 (15:53 +0200)]
Revert "HACK FSCTL_LMR_REQ_RESILIENCY..."

This reverts commit 1c3fb11f555be90143e9c357e28c8e98debe3ea9.

4 years agoHACK FSCTL_LMR_REQ_RESILIENCY...
Stefan Metzmacher [Fri, 5 Sep 2014 22:11:03 +0000 (00:11 +0200)]
HACK FSCTL_LMR_REQ_RESILIENCY...

4 years agoTODO:TEST! s3:modules: add vfs_io_uring module
Stefan Metzmacher [Wed, 5 Jun 2019 15:01:49 +0000 (17:01 +0200)]
TODO:TEST! s3:modules: add vfs_io_uring module

The module makes use of the new io_uring infrastructure
(intruduced in linux 5.1), see https://lwn.net/Articles/778411/ and
http://git.kernel.dk/cgit/liburing/

TODO: this module compiles, but was not runtime tested yet.

4 years agos3:smb2_lock: implement lock_sequence replay detection
Stefan Metzmacher [Wed, 24 Oct 2012 13:55:20 +0000 (15:55 +0200)]
s3:smb2_lock: implement lock_sequence replay detection

While windows enables it only for resilient and persistent handles a SMB server
SHOULD (according to MS-SMB2 section 3.3.5.14 ) activate processing of lock
sequence numbers for EITHER
- protocol dialect 2.1 and resilient handles OR
- protocol dialect 3.x.

Pair-Programmed-With: Michael Adam <obnox@samba.org>
Pair-Programmed-With: Guenther Deschner <gd@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agos3:smb2_lock: pass in_lock_sequence to smbd_smb2_lock_send()
Stefan Metzmacher [Wed, 24 Oct 2012 12:53:05 +0000 (14:53 +0200)]
s3:smb2_lock: pass in_lock_sequence to smbd_smb2_lock_send()

Take the value from the client if the dialect is SMB2_10 or higher,
otherwise default to 0.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3:smbXsrv_open: initialize smbXsrv_open_global->lock_sequence_array with 0xFF
Stefan Metzmacher [Wed, 24 Oct 2012 13:17:56 +0000 (15:17 +0200)]
s3:smbXsrv_open: initialize smbXsrv_open_global->lock_sequence_array with 0xFF

This does not match the current documentation, but is very likely the
right thing to do.

If we would match the documentation and initialize with 0x00,
we would return STATUS_SUCCESS without doing any locks.
If the client also follows the documentation and starts
with a lock_sequence of 0 for the first operation.

Pair-Programmed-With: Michael Adam <obnox@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
4 years agos3:smbXsrv.idl: add lock_sequence_array to smbXsrv_open_global0
Stefan Metzmacher [Wed, 24 Oct 2012 13:06:54 +0000 (15:06 +0200)]
s3:smbXsrv.idl: add lock_sequence_array to smbXsrv_open_global0

This is needed for lock replay detection.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4:torture/smb2: add smb2.lock.replay_smb3_specification test
Stefan Metzmacher [Wed, 2 Oct 2019 13:30:53 +0000 (15:30 +0200)]
s4:torture/smb2: add smb2.lock.replay_smb3_specification test

This implements a test that checks for the specified behaviour.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agos4:torture/smb2: make smb2.lock.replay_broken_windows more obvious
Stefan Metzmacher [Wed, 2 Oct 2019 12:51:26 +0000 (14:51 +0200)]
s4:torture/smb2: make smb2.lock.replay_broken_windows more obvious

This test check the SMB 2.1.0 behaviour of lock sequence checking,
which is only turned on for resilient handles.

Even Windows Server 2019 only implements lock sequence checking only
for resilient and persistent handles as a server.
While its client side uses lock sequence checking if it negotiated
multichannel with the server.

Hopefully this will be fixed in future Windows versions.

Make it clear that this test is supposed to pass against the legacy
Windows servers which violate the specification:

  [MS-SMB2] 3.3.5.14 Receiving an SMB2 LOCK Request

  ...

  If the LockSequence value in the SMB2 LOCK Request (section 2.2.26) is not zero,
  and either one of the following conditions is TRUE, the server SHOULD verify
  whether the lock/unlock request with that LockSequence value has been
  successfully processed before:
  * Connection.Dialect is "2.1" and Open.IsResilient is TRUE.
  * Connection.Dialect belongs to the SMB 3.x dialect family.<318>

  ...

  <318> Section 3.3.5.14: Windows 8, Windows Server 2012, Windows 8.1, and Windows Server 2012
  R2 do not verify the LockSequence value in the SMB2 LOCK Request (section 2.2.26) when both
  Open.IsResilient and Open.IsPersistent are FALSE.

Note <318> also applies to Windows Server 2016 and 2019.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
4 years agos4:torture/smb2: fix and improve the smb2.lock.replay test
Michael Adam [Thu, 20 Sep 2018 10:45:17 +0000 (12:45 +0200)]
s4:torture/smb2: fix and improve the smb2.lock.replay test

The test was wrong in that it used an invalid
lock sequence bucket (65) where it actually wanted
to use a valid on (64), and hence the test results
(which were adapted to the real responses) were not
quite logical.

This patch fixes this and also improves some of
the comments so that the flow of the patch becomes
a little more obvious.

Pair-Programmed-With: Günther Deschner <gd@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoaudit_logging: Don't spam the logs if dsdb_event is not found
Andreas Schneider [Fri, 11 Oct 2019 06:28:30 +0000 (08:28 +0200)]
audit_logging: Don't spam the logs if dsdb_event is not found

This gets only registered by our tests.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 14 07:41:52 UTC 2019 on sn-devel-184

4 years agos3:libads: Do not turn on canonicalization flag for MIT Kerberos
Andreas Schneider [Wed, 9 Oct 2019 14:32:47 +0000 (16:32 +0200)]
s3:libads: Do not turn on canonicalization flag for MIT Kerberos

This partially reverts 303b7e59a286896888ee2473995fc50bb2b5ce5e.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14155

Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com>

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Oct 12 17:39:13 UTC 2019 on sn-devel-184

4 years agotestprogs: Add test for kinit with canonicalization
Andreas Schneider [Wed, 9 Oct 2019 14:59:59 +0000 (16:59 +0200)]
testprogs: Add test for kinit with canonicalization

Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com>

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4:selftest: Do not print the target env twice
Andreas Schneider [Wed, 9 Oct 2019 14:57:11 +0000 (16:57 +0200)]
s4:selftest: Do not print the target env twice

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agogitlab-ci: Run several AD tests with MIT KDC
Andreas Schneider [Wed, 9 Oct 2019 13:55:50 +0000 (15:55 +0200)]
gitlab-ci: Run several AD tests with MIT KDC

This will avoid introducing regressions in either client or server code.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos4:selftest: Do not print the target env twice
Andreas Schneider [Thu, 10 Oct 2019 07:14:24 +0000 (09:14 +0200)]
s4:selftest: Do not print the target env twice

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agolib:krb5_wrap: Do not create a temporary file for MEMORY keytabs
Andreas Schneider [Wed, 9 Oct 2019 18:11:03 +0000 (20:11 +0200)]
lib:krb5_wrap: Do not create a temporary file for MEMORY keytabs

The autobuild cleanup script fails with:

The tree has 3 new uncommitted files!!!
git clean -n
Would remove MEMORY:tmp_smb_creds_SK98Lv
Would remove MEMORY:tmp_smb_creds_kornU6
Would remove MEMORY:tmp_smb_creds_ljR828

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agospnego: fix server handling of no optimistic exchange
Isaac Boukris [Wed, 4 Sep 2019 14:04:12 +0000 (17:04 +0300)]
spnego: fix server handling of no optimistic exchange

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sat Oct 12 15:51:42 UTC 2019 on sn-devel-184

4 years agopython/tests/gensec: add spnego downgrade python tests
Isaac Boukris [Thu, 10 Oct 2019 21:20:16 +0000 (00:20 +0300)]
python/tests/gensec: add spnego downgrade python tests

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Pair-Programmed-With: Andreas Schneider <asn@samba.org>

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agopython/tests/gensec: make it possible to add knownfail tests for gensec.update()
Stefan Metzmacher [Fri, 11 Oct 2019 11:23:17 +0000 (13:23 +0200)]
python/tests/gensec: make it possible to add knownfail tests for gensec.update()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agoselftest: add tests for no optimistic spnego exchange
Isaac Boukris [Wed, 4 Sep 2019 13:39:43 +0000 (16:39 +0300)]
selftest: add tests for no optimistic spnego exchange

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agospnego: add client option to omit sending an optimistic token
Isaac Boukris [Wed, 4 Sep 2019 13:31:21 +0000 (16:31 +0300)]
spnego: add client option to omit sending an optimistic token

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agoselftest: s3: add a test for spnego downgrade from krb5 to ntlm
Isaac Boukris [Mon, 7 Oct 2019 20:51:19 +0000 (23:51 +0300)]
selftest: s3: add a test for spnego downgrade from krb5 to ntlm

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agos3:libsmb: Do not check the SPNEGO neg token for KRB5
Andreas Schneider [Thu, 10 Oct 2019 14:18:21 +0000 (16:18 +0200)]
s3:libsmb: Do not check the SPNEGO neg token for KRB5

The list is not protected and this could be a downgrade attack.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Pair-Programmed-With: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agospnego: ignore server mech_types list
Isaac Boukris [Thu, 3 Oct 2019 10:09:29 +0000 (13:09 +0300)]
spnego: ignore server mech_types list

We should not use the mech list sent by the server in the last
'negotiate' packet in CIFS protocol, as it is not protected and
may be subject to downgrade attacks.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106

Signed-off-by: Isaac Boukris <iboukris@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
4 years agowscript: split function check to one per line and sort alphabetically
Ralph Boehme [Mon, 30 Sep 2019 09:52:06 +0000 (11:52 +0200)]
wscript: split function check to one per line and sort alphabetically

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 10 20:13:25 UTC 2019 on sn-devel-184

4 years agowscript: remove all checks for _FUNC and __FUNC
Ralph Boehme [Mon, 30 Sep 2019 09:49:28 +0000 (11:49 +0200)]
wscript: remove all checks for _FUNC and __FUNC

Those where historic artifacts not needed anymore.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
4 years agoWHATSNEW: Mention performance improvements for SMB3 encryption
Andreas Schneider [Tue, 1 Oct 2019 15:38:57 +0000 (17:38 +0200)]
WHATSNEW: Mention performance improvements for SMB3 encryption

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Oct 10 09:41:26 UTC 2019 on sn-devel-184

4 years agolibrpc: Remove server build of oxidresolver.idl
Andrew Bartlett [Mon, 23 Sep 2019 05:08:56 +0000 (17:08 +1200)]
librpc: Remove server build of oxidresolver.idl

We do not have a server for this DCOM component so do not generate
the code for it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove client and server build of w32time.idl
Andrew Bartlett [Mon, 23 Sep 2019 04:58:35 +0000 (16:58 +1200)]
librpc: Remove client and server build of w32time.idl

We do not have a server for the Win32 Time Server so do not generate
the code for it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove client and server build of rot.idl
Andrew Bartlett [Mon, 23 Sep 2019 04:57:48 +0000 (16:57 +1200)]
librpc: Remove client and server build of rot.idl

We do not have a client or server for this DCOM component so do not generate
the code for it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove s4 server build of dfs
Andrew Bartlett [Mon, 23 Sep 2019 04:47:48 +0000 (16:47 +1200)]
librpc: Remove s4 server build of dfs

We do not have a source4 varient of the dfs server, so do not generate
the code for it.

DFS is very closely tied to SMB so we use the DFS server in
smbd.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove s3 server build of unixinfo
Andrew Bartlett [Mon, 23 Sep 2019 04:40:47 +0000 (16:40 +1200)]
librpc: Remove s3 server build of unixinfo

We do not have a source3 varient of the unixinfo server, so do not generate
the code for it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Add commnets on the split out of IDL files
Andrew Bartlett [Mon, 23 Sep 2019 04:39:11 +0000 (16:39 +1200)]
librpc: Add commnets on the split out of IDL files

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove server build of remact.idl
Andrew Bartlett [Mon, 23 Sep 2019 04:37:31 +0000 (16:37 +1200)]
librpc: Remove server build of remact.idl

We do not have a server for the DCOM Remote activation service, so do not generate
the code for it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove s4 server build of ntsvcs
Andrew Bartlett [Mon, 23 Sep 2019 04:34:19 +0000 (16:34 +1200)]
librpc: Remove s4 server build of ntsvcs

We do not have a source4 varient of the ntsvcs server, so do not generate
the code for it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove s4 server build of initshutdown
Andrew Bartlett [Mon, 23 Sep 2019 04:32:38 +0000 (16:32 +1200)]
librpc: Remove s4 server build of initshutdown

We do not have a source4 varient of the initshutdown server, so do not generate
the code for it.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agolibrpc: Remove unused build of atsvc server
Andrew Bartlett [Mon, 23 Sep 2019 04:31:07 +0000 (16:31 +1200)]
librpc: Remove unused build of atsvc server

This avoids building server-side code we do not use and so makes the build
smaller and code auditing easier.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: Complete the removal of SMB_VFS_RMDIR()
Jeremy Allison [Fri, 4 Oct 2019 22:41:21 +0000 (15:41 -0700)]
s3: VFS: Complete the removal of SMB_VFS_RMDIR()

All users now use SMB_VFS_UNLINKAT(..., AT_REMOVEDIR).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Oct 10 07:26:43 UTC 2019 on sn-devel-184

4 years agos3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 22:23:44 +0000 (15:23 -0700)]
s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.

NB, this will now fail smb_vfs_assert_all_fns()
until we remove the rmdir_fn() from the VFS definitions.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 22:22:19 +0000 (15:22 -0700)]
s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_syncops: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 22:21:21 +0000 (15:21 -0700)]
s3: VFS: vfs_syncops: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_streams_depot: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 22:17:32 +0000 (15:17 -0700)]
s3: VFS: vfs_streams_depot: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_snapper: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 22:10:58 +0000 (15:10 -0700)]
s3: VFS: vfs_snapper: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_shadow_copy2: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 22:10:07 +0000 (15:10 -0700)]
s3: VFS: vfs_shadow_copy2: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_posix_eadb: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 22:09:00 +0000 (15:09 -0700)]
s3: VFS: vfs_posix_eadb: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_media_harmony: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:52:18 +0000 (14:52 -0700)]
s3: VFS: vfs_media_harmony: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_glusterfs: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:51:15 +0000 (14:51 -0700)]
s3: VFS: vfs_glusterfs: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_extd_audit: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:49:54 +0000 (14:49 -0700)]
s3: VFS: vfs_extd_audit: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_ceph_snapshots: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:44:48 +0000 (14:44 -0700)]
s3: VFS: vfs_ceph_snapshots: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_ceph: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:44:08 +0000 (14:44 -0700)]
s3: VFS: vfs_ceph: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_catia: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:43:11 +0000 (14:43 -0700)]
s3: VFS: vfs_catia: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_cap: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:42:26 +0000 (14:42 -0700)]
s3: VFS: vfs_cap: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3: VFS: vfs_audit: Remove rmdir_fn(). No longer used.
Jeremy Allison [Fri, 4 Oct 2019 21:41:26 +0000 (14:41 -0700)]
s3: VFS: vfs_audit: Remove rmdir_fn(). No longer used.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>