s4-rpc: dnsserver: dns_name_equal() returns boolean
authorAmitay Isaacs <amitay@gmail.com>
Thu, 6 Dec 2012 05:05:26 +0000 (16:05 +1100)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 30 May 2013 00:43:46 +0000 (10:43 +1000)
Remove the remaining check for return value after strcmp() was changed to
dns_name_equal().

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/rpc_server/dnsserver/dnsdata.c

index 87b7d87ae3b4e681b95e649204c0f64bca816248..fb2547ff7ecc4c858e7c477339c3ce97d73a213b 100644 (file)
@@ -958,8 +958,8 @@ bool dns_record_match(struct dnsp_DnssrvRpcRecord *rec1, struct dnsp_DnssrvRpcRe
                return dns_name_equal(rec1->data.cname, rec2->data.cname);
 
        case DNS_TYPE_SOA:
-               return dns_name_equal(rec1->data.soa.mname, rec2->data.soa.mname) == 0 &&
-                       dns_name_equal(rec1->data.soa.rname, rec2->data.soa.rname) == 0 &&
+               return dns_name_equal(rec1->data.soa.mname, rec2->data.soa.mname) &&
+                       dns_name_equal(rec1->data.soa.rname, rec2->data.soa.rname) &&
                        rec1->data.soa.serial == rec2->data.soa.serial &&
                        rec1->data.soa.refresh == rec2->data.soa.refresh &&
                        rec1->data.soa.retry == rec2->data.soa.retry &&