Amitay Isaacs [Mon, 27 May 2013 02:26:36 +0000 (12:26 +1000)]
samba-tool/dns: Pass on additional flags when creating zones
Windows DCs require additional flags to be set when creating zones.
This fixes bug #9599.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Amitay Isaacs [Thu, 6 Dec 2012 05:11:18 +0000 (16:11 +1100)]
s4-dns: Support update of SOA records
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Amitay Isaacs [Thu, 6 Dec 2012 05:06:35 +0000 (16:06 +1100)]
s4-rpc: dnsserver: When updating SOA record, use the specified serial
This makes sure that when updating SOA record, the serial is set to the value
sent by client. For all other records, serial is incremented.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Amitay Isaacs [Thu, 6 Dec 2012 05:05:26 +0000 (16:05 +1100)]
s4-rpc: dnsserver: dns_name_equal() returns boolean
Remove the remaining check for return value after strcmp() was changed to
dns_name_equal().
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Thu, 6 Dec 2012 05:04:32 +0000 (16:04 +1100)]
s4-rpc: dnsserver: Fix removal of trailing '.' in soa mname
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Tue, 28 May 2013 10:19:34 +0000 (12:19 +0200)]
build: Add missing new line to replaced python shebang line. (Fix bug #9909)
When configuring with a non-standard python specified in
the PYTHON environment variable, the shebang lines in various
python tools like samba-tool and samba_dnsupdate get replaced.
This replace line for the shebang was missing a newline
which joined the shebang line with the following line,
rendereing those scripts with a nonempty second line unusuable,
for example samba_dnsupdate.
This patch fixes this bug which is bug #9909 on bugzilla.
Pair-Programmed-With: Karolin Seeger <kseeger@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed May 29 13:21:51 CEST 2013 on sn-devel-104
Günther Deschner [Mon, 27 May 2013 12:15:08 +0000 (14:15 +0200)]
s4-torture: Always compile backupkey ndr testsuite.
This removes another incorrect AD_DC_BUILD_IS_ENABLED check ifdef check. The ndr
test is not at all heimdal specific.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed May 29 11:29:51 CEST 2013 on sn-devel-104
David Disseldorp [Tue, 28 May 2013 13:11:45 +0000 (15:11 +0200)]
waf: build PIEs if supported by the compiler
Currently waf performs a mandatory check for compiler PIE support,
unless --without-pie is specified.
This change makes Waf only perform the mandatory check if --with-pie is
specified. If neither --with-pie nor --without-pie are specified, then
PIEs are only built if compiler support is available.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Michael Adam [Tue, 28 May 2013 20:24:26 +0000 (22:24 +0200)]
autobuild: remove remnants of removed samba3 targets
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed May 29 09:35:16 CEST 2013 on sn-devel-104
Michael Adam [Tue, 21 May 2013 14:50:49 +0000 (16:50 +0200)]
net: use smbconf_create_set_share() in "net conf import"
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue May 28 20:01:12 CEST 2013 on sn-devel-104
David Disseldorp [Thu, 16 May 2013 09:55:04 +0000 (11:55 +0200)]
libsmbconf: add smbconf_create_set_share
This call creates a new share definition, using the parameters provided
with a smbconf_service structure.
Such an interface allows for simple cloning of services with:
smbconf_get_share(conf_ctx, mem_ctx, base_sharename, &base_service_def);
base_service_def->name = clone_sharename;
smbconf_create_set_share(conf_ctx, base_service_def);
Pair-Programmed-With: Michael Adam <obnox@samba.org>
Signed-off-by: David Disseldorp <ddiss@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Mon, 20 May 2013 21:30:14 +0000 (23:30 +0200)]
libsmbconf: fix documentation of transaction calls.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Thu, 16 May 2013 07:51:56 +0000 (17:51 +1000)]
dsdb-repl_meta_data: Move TODO comment about conflicts and missing parents
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue May 28 18:11:00 CEST 2013 on sn-devel-104
Andrew Bartlett [Thu, 16 May 2013 05:24:25 +0000 (15:24 +1000)]
torture: Add tests of rename behaviour to replica_sync.py
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 16 May 2013 05:19:20 +0000 (15:19 +1000)]
dsdb-repl_meta_data: Handle renames better, considering only the RDN as given, and then the parent as given
This ignores the full DN as given, because the parent compents might be out of date.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 16 May 2013 03:52:51 +0000 (13:52 +1000)]
dsdb-linked_attributes: Do not crash if the target GUID can not be found
Note that we must not give an error when we cannot find the object
that should hold the backlink, there really isn't anything we can do
in this case.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Rusty Russell [Tue, 28 May 2013 07:23:56 +0000 (16:53 +0930)]
tdb: fix logging of offets and lengths.
We can have offsets > 2G, so use unsigned values. Fixes other prints to be
native types rather than casts, too.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 28 11:22:14 CEST 2013 on sn-devel-104
Amitay Isaacs [Thu, 6 Dec 2012 05:10:42 +0000 (16:10 +1100)]
s4-dns: Print/Set minimumTTL value in SOA record
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 28 08:47:56 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 22 May 2013 23:37:10 +0000 (09:37 +1000)]
build: Remove unused mkbuildoptions.awk
This is not used by the waf build.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 07:05:11 +0000 (17:05 +1000)]
build: Remove unused tool for config.h comparison
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 06:23:23 +0000 (16:23 +1000)]
build: Remove feature tests for variables now always provided
These #ifdef statements were added in replacement for #if (_SAMBA_BUILD_ >= 4)
in
fbe7ed79b0f056a9a8f44a9b42e887441d2f00d5
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 06:16:31 +0000 (16:16 +1000)]
build: Remove unused credentials_samba3.c
This file was only used by the autoconf build system.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 06:13:21 +0000 (16:13 +1000)]
selftest: VFSLIBDIR is not needed, the waf build knows where to find modules automatically
This is why was relinks on install, because it is fixing these
internal variables up.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 04:22:36 +0000 (14:22 +1000)]
build: Remove autoconf build system from examples/VFS
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 03:48:35 +0000 (13:48 +1000)]
passdb-machine_account_secrets: Remove #if SAMBA_BUILD_ == 4 now we only have the waf build
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 03:47:50 +0000 (13:47 +1000)]
nsswitch: Remove #if SAMBA_BUILD_ >= 4 now we only have the waf build
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 03:46:16 +0000 (13:46 +1000)]
lib/util/modules.c: Remove #if SAMBA_BUILD_ == 3 now we only have the waf build
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 03:44:59 +0000 (13:44 +1000)]
param: Remove _SAMBA_BUILD_ checks from now the autoconf build is gone
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:47:59 +0000 (12:47 +1000)]
docs: Document removal of the autoconf build system
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:39:59 +0000 (12:39 +1000)]
build: Remove unused preproc-dummy.c
This was used by autogen.sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:37:54 +0000 (12:37 +1000)]
build: Remove unused linkmodules.sh script
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:37:34 +0000 (12:37 +1000)]
build: Remove unused revert.sh script
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:37:14 +0000 (12:37 +1000)]
build: Remove unused uninstall*.sh scripts
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:36:34 +0000 (12:36 +1000)]
build: Remove unused install*.sh scripts
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:35:15 +0000 (12:35 +1000)]
build: Remove unused build_idl.sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:32:55 +0000 (12:32 +1000)]
Remove lib/netapi autoconf build system, this is now build with waf
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:30:10 +0000 (12:30 +1000)]
build: Remove unused build_idl.sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:27:33 +0000 (12:27 +1000)]
Remove now-unused s3-selftest.sh wrapper
This is now always invokes via waf.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:26:35 +0000 (12:26 +1000)]
Remove stub ldb_version.h and source3/include/autoconf as no longer needed
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:25:45 +0000 (12:25 +1000)]
build: Remove autoconf directory no longer needed
This was only needed to avoid autoconf and waf builds colliding.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:24:16 +0000 (12:24 +1000)]
build: Remove unused script/mkversion.sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:23:56 +0000 (12:23 +1000)]
build: Remove unused install-sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 02:23:20 +0000 (12:23 +1000)]
build: Remove autoconf build system
We are now confident that that waf build system meets enough of our needs
that we will work to improve it, rather than maintain two build systems.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 04:23:31 +0000 (14:23 +1000)]
build: No longer run autogen.sh during tarball creation
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Andrew Bartlett [Wed, 22 May 2013 04:35:08 +0000 (14:35 +1000)]
autobuild: Remove samba3 and samba3-ctdb targets to allow autoconf removal for 4.1
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
David Disseldorp [Mon, 27 May 2013 15:57:01 +0000 (17:57 +0200)]
waf: build position independent executables
This patch re-instates support for building Position Independent
Executables using the '-fPIE' and '-pie' compiler and linker flags
respectively.
PIE builds are enabled by default, and can be explicitly disabled using
the '--without-pie' configure argument.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue May 28 02:56:36 CEST 2013 on sn-devel-104
David Disseldorp [Mon, 27 May 2013 15:57:00 +0000 (17:57 +0200)]
waf: add --with[out]-pie configure arguments
The arguments do not currently have any effect.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Sun, 26 May 2013 11:05:12 +0000 (21:05 +1000)]
build: Install smbtar in waf build
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 27 12:55:05 CEST 2013 on sn-devel-104
Andrew Bartlett [Sun, 26 May 2013 10:29:19 +0000 (20:29 +1000)]
docs: Remove all references to testprns
Based on debian patch documentation2.patch by Christian Perrier <bubulle@debian.org>.
This tool no longer exists in Samba.
Andrew Bartlett
Reviewed-by: Kai Blin <kai@samba.org>
Andrew Bartlett [Wed, 22 May 2013 21:34:15 +0000 (07:34 +1000)]
build: Remove duplicate call to bld.SYMBOL_CHECK()
This was missed when we merged the two waf systems.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 27 10:30:06 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 22 May 2013 23:51:36 +0000 (09:51 +1000)]
build: Remove mkinstalldirs
This is not used in the waf build.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Thu, 23 May 2013 03:17:19 +0000 (13:17 +1000)]
lib/replace: Remove unused install-sh
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon May 27 05:51:04 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 22 May 2013 23:51:03 +0000 (09:51 +1000)]
build: Remove unused expand-includes.pl
We no longer have makefiles with includes.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Wed, 22 May 2013 23:38:47 +0000 (09:38 +1000)]
build: Remove old create-tarball release script
Releases are now done via "waf dist" and script/librelease.sh.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Wed, 22 May 2013 23:33:19 +0000 (09:33 +1000)]
build: Do not always regenerate the version.h file
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 21:37:33 +0000 (07:37 +1000)]
smbd: Fix build on platforms that will not support var = {} initialisation
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:13:52 +0000 (00:13 +1000)]
examples: Remove browser and DC settings from example smb.conf
These examples just encourage folks to set browing values that are not needed.
The domain logons setting is already covered by the server role at the
top of the file and logon script is not special enough to be in the
default smb.conf.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:12:23 +0000 (00:12 +1000)]
examples: Remove password server from example smb.conf
This should discourage folks from setting it when they do not really need it.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:11:32 +0000 (00:11 +1000)]
examples: Remove default printing form example smb.conf
These settings are all defaults, and just work for most systems. Users on other platforms
can read man smb.conf, rather than cluttering up this file.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:10:39 +0000 (00:10 +1000)]
examples: Move example smb.conf over to "server role"
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:14:29 +0000 (00:14 +1000)]
build: Rework BSD_STYLE_STATVFS check to match autoconf build
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Sun, 26 May 2013 13:11:03 +0000 (23:11 +1000)]
build: Remove binaries and libraries build groups
Build groups are used in Samba to ensure that even if the dependency
chain for a target is not perfect, that it builds reliably. This
matters most in the early build stages, where we are building the asn1
compiler and autogenerating files.
Once we get to the main stage, dependencies between C files, libraries
and binaries are much clearer, because the C compiler and linker takes
these as inputs anyway.
Groups were added to our waf build for stability during early
development, as dependency information was first imported from the
previous autoconf/perl based build system.
I don't think we need this distinction in the main build of C files
into .o, and when linking these into binaries, because the invocation
of these tools is very well defined, and we will find any missing
inputs very quickly.
As such, I've removed the libraries and binaries targets,
consolidating them with 'main'
By making this change, a build of smbtorture only on a clean tree
drops from 3778 to 2489 targets, and much of the expensive linker
stage is skipped. The time for a null build of smbtorture only also
drops from 4.673s to as low as 2.499s on my laptop.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Sun, 26 May 2013 22:27:44 +0000 (08:27 +1000)]
build: Build all of samba in autoconf make test
The test system actually depends on far more than smbtorture these days
and this was masked by the build groups. Rather than try and specify
everything that could be used, just build the lot (which is what was
essentially being done anyway).
This prepares for the removal of the libraries and binaries build
groups, to assist in improving waf performance for single-binary builds.
Andrew Bartlett
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Michael Adam [Wed, 24 Apr 2013 13:49:46 +0000 (15:49 +0200)]
s4:idmap: break account_type check lines for readability in idmap_sid_to_xid()
Also makes code obey README.Coding, regarding line-length.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon May 27 00:05:19 CEST 2013 on sn-devel-104
Kai Blin [Sat, 25 May 2013 12:05:22 +0000 (14:05 +0200)]
idl: Add DNS HINFO record support
Not sure if we need this, bug samba.org specifies it, so this can cause ANY queries
against samba.org to fail.
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sun May 26 20:05:38 CEST 2013 on sn-devel-104
Kai Blin [Sat, 25 May 2013 12:05:21 +0000 (14:05 +0200)]
idl: Add DNS RP record support as per RFC 1183
Not sure if we need this, but samba.org specifies it, so this could cause ANY
queries against samba.org to fail.
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Kai Blin [Sat, 25 May 2013 11:21:33 +0000 (13:21 +0200)]
dns: Support larger queries when asking forwarder
This should fix bug #9632
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Kai Blin [Sat, 25 May 2013 11:21:32 +0000 (13:21 +0200)]
idl: Add support for parsing OPT records
Signed-off-by: Kai Blin <kai@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Christof Schmitt [Fri, 24 May 2013 19:40:49 +0000 (12:40 -0700)]
winbind: Print error code on connection error in ping_dc
For debugging, it is useful to include the error code in the message.
Signed-off-by: Christof Schmitt <christof.schmitt@us.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sat May 25 23:11:23 CEST 2013 on sn-devel-104
Vadim Zhukov [Sat, 25 May 2013 14:19:24 +0000 (15:19 +0100)]
pidl: Recent Perl warns about "defined(@var)" constructs.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat May 25 18:10:53 CEST 2013 on sn-devel-104
Anand Avati [Fri, 24 May 2013 19:23:06 +0000 (12:23 -0700)]
building RPMs on RHEL fail because of a typo.
Signed-off-by: Anand Avati <avati@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 25 01:04:37 CEST 2013 on sn-devel-104
Stefan Metzmacher [Fri, 17 May 2013 21:18:55 +0000 (23:18 +0200)]
libnet-vampire: make use of dsdb_repl_resolve_working_schema()
Pair-Programmed-With: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu May 23 14:18:03 CEST 2013 on sn-devel-104
Stefan Metzmacher [Fri, 17 May 2013 21:18:41 +0000 (23:18 +0200)]
dsdb-repl: merge the logic from libnet_vampire_cb_apply_schema()
This way libnet_vampire_cb_apply_schema() is able to use
dsdb_repl_resolve_working_schema().
Pair-Programmed-With: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Stefan Metzmacher [Fri, 17 May 2013 21:02:03 +0000 (23:02 +0200)]
dsdb-repl: split out dsdb_repl_resolve_working_schema
This can be reused later in other places.
Pair-Programmed-With: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Fri, 19 Apr 2013 05:03:23 +0000 (22:03 -0700)]
selftest: Improve test coverage of DRS (bug #8680)
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Sun, 27 Jan 2013 23:43:07 +0000 (15:43 -0800)]
dsdb-drs: when replicating schema object checks ask for removal of previous version if exists (bug #8680)
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Mon, 8 Oct 2012 04:46:38 +0000 (21:46 -0700)]
libnet-vampire: add attributes and classes from the replicated schema to the bootstrap schema (bug #8680)
Replicated schema might have attributes and auxilary classes on some
critical classes (ie. top, user, computer ) that are not in the bootstrap
schema. Without those new attributes and classes, bootstrap schema is
unable to translate those critical classes in the schema constructed
from the replicated data. Without thoses classes new schema is useless
and can't be indexed properly.
In order to overcome this problem, we put all new attributes and classes
definitions into the bootstrap schema so that foundations classes can be
translated.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Matthieu Patou [Sun, 27 Jan 2013 07:42:10 +0000 (23:42 -0800)]
dsdb-schema: make deduplication of class and schema possible (bug #8680)
When a class or an attribute is replicated it might already exists in
the existing schema, so while replicating the new version of this object
we want to get rid of the old version of the object is the current
validating schema so that we don't end up having duplicates.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Stefan Metzmacher [Thu, 23 May 2013 06:46:31 +0000 (08:46 +0200)]
dsdb-schema: schema_fill_possible_inferiors() should rebuild everthing
commit
cd7f3fd07215a7b8372b6b623faed02ae1310cb1 reverted the change
of commit
c2853f55fc603d4875bb1e50a1cbf409df0421ea.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Richard Sharpe [Thu, 23 May 2013 03:05:17 +0000 (20:05 -0700)]
Revert my accidental commit.
Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Thu May 23 06:53:17 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 22 May 2013 07:23:30 +0000 (17:23 +1000)]
lib/replace: Set BROKEN_STRNLEN and BROKEN_STRNDUP on all AIX
The background is in https://bugzilla.samba.org/show_bug.cgi?id=1097
and wider reports are at
http://stackoverflow.com/questions/
2091460/strndup-call-is-currupting-stack-frames
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 23 03:52:10 CEST 2013 on sn-devel-104
Andrew Bartlett [Tue, 21 May 2013 10:44:26 +0000 (20:44 +1000)]
docs: Fix small errors in TOSHARG-Compiling
Reviewed-by: Jeremy Allison <jra@samba.org>
Andrew Bartlett [Tue, 21 May 2013 10:50:30 +0000 (20:50 +1000)]
docs: Remove TOSHARG-HighAvailability which is made obsolete by CTDB
This is mostly a lament on why this is hard, and while CTDB is still
hard, this document tries to imply it is almost impossible, and makes
no mention of the solution.
Andrew Bartlett
Reviewed-by: Jeremy Allison <jra@samba.org>
Andrew Bartlett [Tue, 21 May 2013 07:49:55 +0000 (17:49 +1000)]
docs: Remove out of date and unmaintained Speed page from the HOWTO
Reviewed-by: Jeremy Allison <jra@samba.org>
Peng Haitao [Wed, 22 May 2013 21:03:13 +0000 (14:03 -0700)]
When message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPGRADE.
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Peng Haitao [Wed, 22 May 2013 21:02:29 +0000 (14:02 -0700)]
When '--policies-reset' is success, the exit code should be 0.
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Tue, 21 May 2013 14:14:19 +0000 (00:14 +1000)]
build: Update md5.h detection in waf and autoconf to use sys/md5.h and -lmd
This brings the two build systems in sync, without using md5.h (which is a problem name)
Tested on FreeBSD
Andrew Bartlett
Reviewed-by: Richard Sharpe <rsharpe@samba.org>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Wed May 22 10:06:40 CEST 2013 on sn-devel-104
Richard Sharpe [Sat, 11 May 2013 16:47:23 +0000 (09:47 -0700)]
Make sure that if an smbd is exiting because of an error we let the user know.
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
Günther Deschner [Fri, 17 May 2013 09:23:22 +0000 (11:23 +0200)]
s4-torture: No need to disable rpc.spoolss.win test when compiled with MIT kerberos.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon May 20 20:35:33 CEST 2013 on sn-devel-104
Günther Deschner [Fri, 1 Feb 2013 13:53:12 +0000 (14:53 +0100)]
selftest: mark the spoolss add print processor tests as knownfail for now.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 1 Feb 2013 13:07:50 +0000 (14:07 +0100)]
s4-torture: add simple tests for spoolss_{Add|Delete}PrintProcessor.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 1 Feb 2013 13:07:07 +0000 (14:07 +0100)]
doserr: add mapping for WERR_PRINT_PROCESSOR_ALREADY_INSTALLED.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Fri, 1 Feb 2013 01:34:11 +0000 (02:34 +0100)]
spoolss: fill in IDL for spoolss_DeletePrintProcessor.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 31 Jan 2013 21:06:20 +0000 (22:06 +0100)]
s4-torture: also deal with "Microsoft XPS Document Writer v4" as default driver.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 31 Jan 2013 13:56:17 +0000 (14:56 +0100)]
s4-torture: add ndr test for spoolss_RpcSetJobNamedProperty.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Tue, 22 Jan 2013 09:17:27 +0000 (10:17 +0100)]
s4-torture: add ndr test for spoolss_GetCorePrinterDrivers.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 31 Jan 2013 19:44:54 +0000 (20:44 +0100)]
s4-torture: add simple test for spoolss_RpcSendRecvBidiData.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Mon, 21 Jan 2013 21:09:22 +0000 (22:09 +0100)]
s4-torture: add test for spoolss_RpcEnumJobNamedProperties.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Sun, 24 Feb 2013 13:06:59 +0000 (14:06 +0100)]
spoolss: add spoolss_MonitorContainer IDL.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Günther Deschner [Thu, 24 Jan 2013 22:31:19 +0000 (23:31 +0100)]
spoolss: make RPC_PrintNamedProperty public
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>