more python/samba/tests/credentials.py tests TODO

sq cli_credentials_ccache_update_principal

Revert "HACK force small buffers"

This reverts commit f98759046f93bcd2188b660b4f69190638d24628.

Revert "HACK large enumprinters trigger transs"

This reverts commit 7ffbe3e4590c89cba1203a95280afaa28fb05575.

HACK large enumprinters trigger transs

HACK force small buffers

Revert "FIXME??? testprogs: Change in semantics"

This reverts commit 67fd8a7a5cb7cea7dbcd99e0b4fd9d0a1915a58c.

FIXME??? testprogs: Change in semantics

s3-script: Use correct username and realm to access the ktest ccache

We want to access the cache of Administrator@KTEST.SAMBA.EXAMPLE.COM so
specify the correct username in the test and don't use foo@FOO.

WAS 4a86dd6b375502f73aaea091b1da03f2df60d0e1

Revert "TODO: auth: Do not set emtpy passwords for credentials in cli_credentials_parse_string()"

This reverts commit da3af7f43962250491d0a5ae8433121767c2a892.

Revert "hack.. don't handle @"

This reverts commit 1b0f390c2e142d57c32bbb5115e43fcaee0f75df.

hack.. don't handle @

auth/ntlmssp: remove unused gensec_ntlmssp_server_domain()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

s3:libsmb: don't use gensec_ntlmssp_server_domain()

This is a layer violation and this information is not
when using kerberos.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

MORE places??? TODO??? s3:net: call fault_setup() in order to get usefull backtraces

reproduce-try1.sh

run this in TDB_NO_FSYNC=1 make -j testenv SELFTEST_TESTENV=vampire_dc SCREEN=1 SAMBA_OPTIONS="-d4"

smb_krb5_dump

libgpo: pass cli_credentials instead of ADS_STRUCT to check_refresh_gpo*()

libgpo: make use of cli_full_connection_creds()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

ads_struct

TODO: s3-libads: Pass cli_credentials to ads_sasl_spnego_gensec_bind()

Signed-off-by: Andreas Schneider <asn@samba.org>

TODO CRED_MUST_USE_KERBEROS without password s3-libads: Simplify ads_sasl_spnego_bind()

s3-libads: Use gensec GSSAPI for ads_sasl_gssapi_bind()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

auth: Add cli_credentials_ccache_update_principal()

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Add cli_credentials_ccache_get()

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Return username in get_principal if it contains an '@'

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Do not invalidate the cache on set_principal

Signed-off-by: Andreas Schneider <asn@samba.org>

Revert "auth: Call cli_credentials_ccache_reinit() in set_principal"

This reverts commit 2bfe4d053cb3e1bc4ed8acd050bc6861ece49105.

auth: Call cli_credentials_ccache_reinit() in set_principal

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Add new cli_credentials_ccache_destroy() function

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Add cli_credentials_ccache_reinit()

Signed-off-by: Andreas Schneider <asn@samba.org>

krb5_samba: Add krb5_free_string macro for Heimdal build

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Add a new cli_credentials_ccache_init()

Signed-off-by: Andreas Schneider <asn@samba.org>

s4-libsmb: Do not set empty password for gensec

GENSEC expects NULL as no password. There are too many places which
set "" instead of NULL. We plan to pass down the cli_credentials
structure anyway so this workaround should be ok for now.

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Do not set an empty realm

Just remove the @ sign and use it as a username.

Signed-off-by: Andreas Schneider <asn@samba.org>

auth: Do not set emtpy passwords for credentials

Signed-off-by: Andreas Schneider <asn@samba.org>

SKIP TESTS - DONT PUSH

sq gensec_gssapi_map_krb5_error

krb5 fallback

s4 make use of gensec_gssapi_try_kerberos()

TODO s4:auth/gensec: make use of gensec_gssapi... GENSEC_GSSAPI_HELPER

use gensec_gssapi_try_kerberos in source3/librpc/crypto/gse.c

auth/kerberos: add gensec_gssapi_try_kerberos()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

TODO improve pdb_samba_dsdb_get_trusteddom_creds

s3:libads: let get_kdc_ip_string() also return kpasswd_server entries for each kdc

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12515

Signed-off-by: Stefan Metzmacher <metze@samba.org>

s3:libads: improve the logic in get_kdc_ip_string()

This fixes possible memory leaks on 'mem_ctx' and
always adds :88 (also for ipv4 addresses).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12515

Signed-off-by: Stefan Metzmacher <metze@samba.org>

REQUIRE NEW ldb version auth/credentials: use LDB_FLG_DONT_CREATE_DB and avoid creating secrets.ldb on domain members

Signed-off-by: Stefan Metzmacher <metze@samba.org>

s4:param: pass flags via secrets_db_connect() to ldb_wrap_connect()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

sq Test python binding for package_PackagesBlob

selftest: only use the ntvfs server for ad_dc_ntvfs, rpc_proxy, promoted_dc and s4member*

Revert "s3:smbd: unimplement FSCTL_VALIDATE_NEGOTIATE_INFO with "server max protocol = SMB2_02""

This reverts commit def878b3aa74c81303fe4ba3fe69e20ee579dd55.

works

s3:smbd: unimplement FSCTL_VALIDATE_NEGOTIATE_INFO with "server max protocol = SMB2_02"

A client that supports SMB3 will do a signed FSCTL_VALIDATE_NEGOTIATE_INFO
after a tree connect. This FSCTL_VALIDATE_NEGOTIATE_INFO call contains
the client capabilities, client guid, security mode and the array of supported
dialects. But if SMB 2.02 is negotiated the doesn't send these values to the
server in the first connection attempt (when the client starts with a SMB1 Negotiate).

Windows servers that only support SMB2 just return NT_STATUS_FILE_CLOSED
as answer to FSCTL_VALIDATE_NEGOTIATE_INFO.

We should do the same if we just pretend to support SMB 2.02,
as SMB 2.10 always include an SMB2 Negotiate request we can leave it as is.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12772

Signed-off-by: Stefan Metzmacher <metze@samba.org>

run samba3.blackbox.smbclient_auth.plain with -mSMB...

selftest: run nt4_member with server max protocol = SMB3_02

This makes sure we don't regress with it.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Revert "s3:smbd: unimplement FSCTL_VALIDATE_NEGOTIATE_INFO with "server max protocol = SMB2_02""

This reverts commit efa5e47869ee88e5984e6763a40efa1eb2e64c9e.

Test python binding for package_PackagesBlob

Signed-off-by: Arvid Requate <requate@univention.de>

REVIEW: pidl/Python: make use of pyrpc_string_array_{from,to}_PyList()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
TODO: Reviewed-by: Arvid Requate <requate@univention.de>

pidl/Python: make use of pyrpc_PyStr_AsString() in ConvertStringFromPythonData()

This reduces the amount of generated code a lot.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: generate a ndr_PyLong_AsCheckedLongLong() helper function

This reduces the size of the generated C code a lot.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: generate a ndr_PyLong_AsCheckedUnsignedLongLong() helper function

This reduces the size of the generated C code a lot.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: improve generation of error checking in FromPythonToUnionFunction()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: fix talloc hierachy in FromPythonToUnionFunction()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: avoid generation of dead code in FromUnionToPythonFunction()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: improve error handling in PythonFunctionUnpackOut() results

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: improve error paths for Exceptions during the PyList construction

Signed-off-by: Stefan Metzmacher <metze@samba.org>

pidl/Python: stop processing if fail to create a PyObject from a C type

If the conversion from a C variable into a PyObject fails
(typically is raises an Exception), we need to stop processing
and propagate the error.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Revert "Test python binding for package_PackagesBlob"

This reverts commit cfc69410bbf4598fd18e1e1bce262e8a247df926.

Test python binding for package_PackagesBlob

Signed-off-by: Arvid Requate <requate@univention.de>

SIGN-OFF s4:pyrpc: add pyrpc_string_array_{from,to}_PyList()

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

TODO: Signed-off-by: Arvid Requate <requate@univention.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>

s4:pyrpc: add pyrpc_PyStr_AsString() helper function

This contains the logic that's currently used in the pidl generated
python bindings. Moving this to a helper function will remove a lot
of generated code.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

talloc: improve pytalloc error code paths if talloc* fails

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Revert "TODO pyrpc_string_array_{from,to}_PyList()"

This reverts commit 27ec6e04894422e9988674985f8055bb9c7a6764.

TODO pyrpc_string_array_{from,to}_PyList()

cli_state_update_after_negprot source3/libsmb/cliconnect.c server_os...

overwrite... in cli_state_update_after_sesssetup

Revert "TODO NOT NEEDED cli_connect_sock_send/recv return sock_storage"

This reverts commit 6c0bd63a73bf8140fb92ea6896008109a0598097.

TODO NOT NEEDED cli_connect_sock_send/recv return sock_storage

Revert "s3:selftest: also run test_smbclient_s3.sh with PROTO=SMB3"

This reverts commit b689e911a42481aa5a66827bbf0b80b93d60c5f8.

s3:libsmb: change the connect banner to "Server=[%s] Protocol=[%s]"

s3:libsmb: pass an optional const struct sockaddr_storage *dest_ss to cli_cm_open()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

s3:libsmb: pass 'dest_ss' from cli_cm_connect() via do_connect() to cli_connect_nb()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

TODO use cli_state_dup

TODO: s3:libsmb: add cli_state_dup()

This can be used to create a 2nd cli_state for
a different tcon on the same connection/session.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Revert "run_oplock_cancel"

This reverts commit fbd15d778d26c3061140537b64a4e6dc5baf5dad.

run_oplock_cancel

Revert "WORKS BUT NOT NEEDED s3:smbd: allow cancelling deferred SMB1 opens"

This reverts commit bf5b33b83f7d0ca13d07d8c53651b8664df137ac.

WORKS BUT NOT NEEDED s3:smbd: allow cancelling deferred SMB1 opens

The Windows 2012R2 behaviour seems to be a NTCREATE response
with STATUS_CANCELLED, but the underlying open is not really
cancelled and a following open get SHARING_VIOLATION.

Revert "s3:libsmb: remove unused show_sessetup handling from do_connect()"

This reverts commit b6f66cf85fafa08aed5692d76940908854310e93.

Revert "more enctypes..."

This reverts commit f5cfd4aa8b4dfb442f1abfc61ef66cdb0b8cd09a.

more enctypes...

Revert "HACK... https://bugzilla.samba.org/show_bug.cgi?id=12892"

This reverts commit 4da2a7a9f9261ab18207699a102069040b652c24.

HACK... https://bugzilla.samba.org/show_bug.cgi?id=12892

s3:libsmb: add support for SMB2/3 in cli_chkpath()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12968

Signed-off-by: Stefan Metzmacher <metze@samba.org>

debug REVISION_MISMATCH

more [flag(NDR_SECRET)]...

.gitlab-ci.yml: merge .gitlab-ci-private.yml

`.gitlab-ci.yml` support conditional jobs with `only` and `except`.
And variables can be read from repo CI/CD settings as condition:

    build_samba:
      script: ...
      only:
        variables:
          - $SUPPORT_PRIVATE_TEST == 'yes'

Instead of having 2 copies of yml file, we can use this feature to
trigger private jobs only when a var like `SUPPORT_PRIVATE_TEST` is defined.

I've already added above var to our repos.
Once merged, we can remove custom CI config file in
gitlab repo settings, and remove .gitlab-ci-private.yml file from code.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb 18 10:54:19 CET 2019 on sn-devel-144

wafsamba/symbols: change regex to match both rpath and runpath for different readelf output

In `wafsamba.dumplicate_symbols` test, it will use Popen to call:

    readelf --dynamic bin/default/source3/lib/netapi/examples/netlogon/netlogon_control2

then try to find rpath lib lines from output with regex:

    re_rpath     = re.compile(b'Library rpath: \[(.*)\]')

In ubuntu 14.04 docker image, which current CI is using, the actual output
from `readelf` is `runpath` instead of 'rpath':

    ...
    Library runpath: [/home/gitlab-runner/samba/bin/shared:/home/gitlab-runner/samba/bin/shared/private]\n'
    ...

So the regex never matched, and hide a bug.

In Ubuntu 1604 docker image, the output changes to `rpath` and matched the
regex, which expose the error in previous commit.

Improve the regex to match both `rpath` and `runpath`.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

wafsamba/symbols: always split Popen output by bytes

In py3, `wafsamba.duplicate_symbols` test may fail:

    ...
    elfpipe = subprocess.Popen(['readelf', '--dynamic', binname], stdout=subprocess.PIPE).stdout
    ...

    File "./buildtools/wafsamba/symbols.py", line 153, in get_libs
        rpath.extend(m.group(1).split(":"))
    TypeError: a bytes-like object is required, not 'str'

Because Popen will always return bytestr even in py3, and ":" is a
unicode str in py3.  Change ":" to b":" to fix.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

selftest: Initialize DC_SERVER/etc variables in one place

It's simpler to do setup DC_SERVER/etc in the same place we set
SERVER/etc. (Rather than initializing them for every single testenv,
like we were doing).

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb 18 07:24:05 CET 2019 on sn-devel-144