Volker Lendecke [Tue, 8 Mar 2011 20:53:22 +0000 (21:53 +0100)]
idmap-autorid: Slightly simplify idmap_autorid_get_domainrange
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:48:44 +0000 (21:48 +0100)]
idmap-autorid: Remove an unused variable
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:47:41 +0000 (21:47 +0100)]
idmap-autorid: Use talloc_tos() in idmap_autorid_id_to_sid
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:45:02 +0000 (21:45 +0100)]
idmap-autorid: Remove an else branch
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:38:21 +0000 (21:38 +0100)]
idmap-autorid: Remove an unused variable
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:36:54 +0000 (21:36 +0100)]
idmap-autorid: Remove an unused parameter
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:33:58 +0000 (21:33 +0100)]
idmap-autorid: Use talloc_tos() in idmap_autorid_sids_to_unixids
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:25:40 +0000 (21:25 +0100)]
idmap-autorid: Not necessary to talloc domaincfg
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 8 Mar 2011 20:17:37 +0000 (21:17 +0100)]
idmap-autorid: Not necessary to talloc domainsid
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Wed, 9 Feb 2011 10:00:00 +0000 (11:00 +0100)]
s3: Cope with 192.168.1.1/24 in smbcontrol ip-dropped
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 18 14:56:38 CET 2011 on sn-devel-104
Günther Deschner [Fri, 18 Mar 2011 12:24:58 +0000 (13:24 +0100)]
s4-libcli/rap: add NDR_RAP dependency to LIBCLI_RAP.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 14:10:57 CET 2011 on sn-devel-104
Günther Deschner [Fri, 18 Mar 2011 12:00:55 +0000 (13:00 +0100)]
s3-waf: enable nss_winbind in make test for nss_wrapper.
Guenther
Günther Deschner [Thu, 17 Mar 2011 14:03:24 +0000 (15:03 +0100)]
s3-registry: remove some unused headers.
Guenther
Stefan Metzmacher [Thu, 17 Mar 2011 09:08:56 +0000 (10:08 +0100)]
s3:locking: simplify the non cluster case of brl_get_locks_readonly()
Pair-Programmed-With: Michael Adam <obnox@samba.org>
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 18 13:00:51 CET 2011 on sn-devel-104
Stefan Metzmacher [Thu, 17 Mar 2011 09:04:12 +0000 (10:04 +0100)]
s3:locking: brl_get_locks_internal() should not expose a write lock if the caller wants read_only
This triggered deadlocks in the cluster case of brl_get_locks_readonly().
Pair-Programmed-With: Michael Adam <obnox@samba.org>
metze
Andrew Tridgell [Fri, 18 Mar 2011 04:02:35 +0000 (15:02 +1100)]
s4-rootdse: improved operations error messages
this gives better localisation of errors in rootdse. This is to help
track down a production error
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Mar 18 05:46:58 CET 2011 on sn-devel-104
Günther Deschner [Fri, 18 Mar 2011 00:23:53 +0000 (01:23 +0100)]
s4-smbtorture: add netsessiongetinfo() test.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 02:11:38 CET 2011 on sn-devel-104
Günther Deschner [Fri, 18 Mar 2011 00:23:29 +0000 (01:23 +0100)]
s4-smbtorture: add missing error code check in test_netsessionenum().
Guenther
Günther Deschner [Fri, 18 Mar 2011 00:22:59 +0000 (01:22 +0100)]
s4-libcli/rap: add smbcli_rap_netsessiongetinfo().
Guenther
Günther Deschner [Fri, 18 Mar 2011 00:22:35 +0000 (01:22 +0100)]
rap: add rap_NetSessionGetInfo to IDL.
Guenther
Günther Deschner [Thu, 17 Mar 2011 23:12:11 +0000 (00:12 +0100)]
s4-smbtorture: add test for rap_NetUserDelete().
Guenther
Günther Deschner [Thu, 17 Mar 2011 22:51:12 +0000 (23:51 +0100)]
s3-net: make sure we set correct default user flags in rap_user_add().
Guenther
Günther Deschner [Thu, 17 Mar 2011 21:18:43 +0000 (22:18 +0100)]
s4-smbtorture: add test for rap_NetUserAdd().
Guenther
Günther Deschner [Thu, 17 Mar 2011 21:39:22 +0000 (22:39 +0100)]
s4-libcli/rap: add smbcli_rap_netuserdelete().
Guenther
Günther Deschner [Thu, 17 Mar 2011 21:38:47 +0000 (22:38 +0100)]
rap: add rap_NetUserDelete IDL.
Guenther
Günther Deschner [Thu, 17 Mar 2011 20:53:19 +0000 (21:53 +0100)]
s4-libcli/rap: add smbcli_rap_netuseradd().
Guenther
Günther Deschner [Thu, 17 Mar 2011 20:52:20 +0000 (21:52 +0100)]
rap: add rap_NetUserAdd IDL.
Guenther
Günther Deschner [Thu, 17 Mar 2011 20:49:23 +0000 (21:49 +0100)]
s4-smbtorture: use torture_assert_ and comment functions in raw.eas test.
Guenther
Günther Deschner [Thu, 17 Mar 2011 20:08:03 +0000 (21:08 +0100)]
s4-smbtorture: use torture_context in raw.eas test.
Guenther
Günther Deschner [Thu, 17 Mar 2011 23:36:39 +0000 (00:36 +0100)]
s4-smbtorture: remove trailing whitespace from raw.eas test.
Guenther
Günther Deschner [Thu, 17 Mar 2011 13:40:38 +0000 (14:40 +0100)]
s3-utils: run minimal_includes.pl over utils/*.c
Guenther
Jeremy Allison [Thu, 17 Mar 2011 23:16:54 +0000 (16:16 -0700)]
The searches struct is still being used and idled in SMB2 - move it to the global
section until we decide if we want to idle SMB2 directory handles.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 18 01:13:53 CET 2011 on sn-devel-104
Jeremy Allison [Thu, 17 Mar 2011 22:55:15 +0000 (15:55 -0700)]
Fix crash bug on smbd shutdown when using FOPENDIR() found by Volker.
The key was allowing the dptr_idle code to be triggered. We were
closing the dirp->dir handle without updating the underlying fd
in the open fsp.
Jeremy.
Volker Lendecke [Thu, 17 Mar 2011 20:13:32 +0000 (21:13 +0100)]
s3: Expose num_opens via api_RNetSessionEnum
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 17 22:05:10 CET 2011 on sn-devel-104
Jeremy Allison [Thu, 17 Mar 2011 17:35:51 +0000 (10:35 -0700)]
Nulling out the op_mid is never the right thing to do. We depend on
this value when searching for specific share mode entries.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 17 19:59:51 CET 2011 on sn-devel-104
Jeremy Allison [Thu, 17 Mar 2011 17:35:10 +0000 (10:35 -0700)]
Fix compiler warning in debug message.
Stefan Metzmacher [Thu, 17 Mar 2011 14:40:17 +0000 (15:40 +0100)]
s3:Makefile.in: make sure we rebuild bin/smbtorture4 if there where changes
and bin/ndrdump4...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Mar 17 16:31:45 CET 2011 on sn-devel-104
Simo Sorce [Thu, 17 Mar 2011 13:02:57 +0000 (09:02 -0400)]
lib-util: put data_blob back in the public library
data_blob is defined ina public header, so it needs to be exposed in the public
library.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Mar 17 15:39:08 CET 2011 on sn-devel-104
Günther Deschner [Thu, 17 Mar 2011 13:07:50 +0000 (14:07 +0100)]
s3-waf: add --with-pam_smbpass configure option.
We build pam_smbpass independent from this configure option though.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 14:52:33 CET 2011 on sn-devel-104
Günther Deschner [Thu, 17 Mar 2011 13:05:48 +0000 (14:05 +0100)]
s3-waf: move HAVE_LDAP_SASL_WRAPPING define to the HAVE_LDAP block.
Guenther
Sumit Bose [Thu, 17 Mar 2011 11:35:35 +0000 (12:35 +0100)]
s3:net Find uid before using it
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 17 Mar 2011 11:25:25 +0000 (12:25 +0100)]
s4-smbtorture: more torture_fail usage in raw.write test.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 13:10:14 CET 2011 on sn-devel-104
Günther Deschner [Wed, 2 Mar 2011 14:22:34 +0000 (15:22 +0100)]
s3-username: rename static getpwnam_alloc to getpwnam_alloc_cached.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 00:32:40 CET 2011 on sn-devel-104
Günther Deschner [Thu, 24 Feb 2011 11:27:29 +0000 (12:27 +0100)]
s3-build: only include asn1 headers where actually needed.
Guenther
Simo Sorce [Wed, 16 Mar 2011 19:32:53 +0000 (15:32 -0400)]
dcerpc: we do not need these as public headers
latest openchange doesn't need these headers either
fix _PRINTF_ATTRIBUTE in tdr.h, as it was failing to work after removing
proto.h due to side effects. PRINTF_ATTRIBUTE is ok and is define in talloc.h
which is included by tdr.h
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Mar 16 23:45:20 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 16 Mar 2011 20:52:20 +0000 (21:52 +0100)]
s3: Fix Coverity ID 2231, REVERSE_INULL
No point in checking for !ctx after dereferencing it
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 22:51:52 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 16 Mar 2011 20:50:59 +0000 (21:50 +0100)]
s3: Fix Coverity ID 2232, REVERSE_INULL
No point checking for !cli after dereferencing it
Volker Lendecke [Wed, 16 Mar 2011 20:48:50 +0000 (21:48 +0100)]
s3: Fix Coverity ID 2233, REVERSE_INULL
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
Volker Lendecke [Wed, 16 Mar 2011 20:47:10 +0000 (21:47 +0100)]
s3: Fix Coverity ID 2234: REVERSE_INULL
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
Volker Lendecke [Wed, 16 Mar 2011 20:34:44 +0000 (21:34 +0100)]
s3: Fix Coverity ID 2140, DEADCODE
This routine was never executed after
f0dcc90f because "netname" was always
NULL.
Jeremy, please check!
Volker Lendecke [Wed, 16 Mar 2011 20:29:02 +0000 (21:29 +0100)]
s3: Fix Coverity ID 2144, DEADCODE
We could never have assigned the real value in line 481.
Andreas, please check!
Volker Lendecke [Wed, 16 Mar 2011 20:24:58 +0000 (21:24 +0100)]
s3: Fix Coverity ID 2147, FORWARD_NULL
How could this ever have worked???
Volker Lendecke [Wed, 16 Mar 2011 20:21:17 +0000 (21:21 +0100)]
s3: Fix Coverity ID 2148, FORWARD_NULL
Further down we unconditionally reference *info
Volker Lendecke [Wed, 16 Mar 2011 19:34:30 +0000 (20:34 +0100)]
s3: Fix Coverity ID 1402: PASS_BY_VALUE
There's no point in passing GROUP_MAP on the stack
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 16 Mar 2011 17:59:28 +0000 (18:59 +0100)]
s3: Fix Coverity ID 2213, PASS_BY_VALUE
There's little point to pass a copy of this structure on the stack.
Günther, please check!
Volker Lendecke [Wed, 16 Mar 2011 17:50:02 +0000 (18:50 +0100)]
s3: Fix Coverity ID 1012, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
Volker Lendecke [Wed, 16 Mar 2011 17:50:02 +0000 (18:50 +0100)]
s3: Fix Coverity ID 1013, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
Volker Lendecke [Wed, 16 Mar 2011 17:47:36 +0000 (18:47 +0100)]
s3: Fix Coverity ID 1017, CHECKED_RETURN
Günther, please check!
Volker Lendecke [Wed, 16 Mar 2011 17:45:50 +0000 (18:45 +0100)]
s3: Fix Coverity ID 1018, CHECKED_RETURN
Volker Lendecke [Wed, 16 Mar 2011 17:42:48 +0000 (18:42 +0100)]
s3: Fix Coverity ID 1034, CHECKED_RETURN
In all other places we check the result of secrets_init.
Volker Lendecke [Wed, 16 Mar 2011 16:55:37 +0000 (17:55 +0100)]
s3: Fix Coverity ID 2100, BAD_SIZEOF
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 16 Mar 2011 16:19:13 +0000 (17:19 +0100)]
s3: Fix Coverity ID 2317: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Wed, 16 Mar 2011 16:19:13 +0000 (17:19 +0100)]
s3: Fix Coverity ID 2318: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Wed, 16 Mar 2011 16:17:47 +0000 (17:17 +0100)]
s3: Fix Coverity ID 2319: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Günther Deschner [Wed, 16 Mar 2011 15:54:31 +0000 (16:54 +0100)]
s4-smbtorture: use torture_assert in torture_samba3_rpc_sharesec().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 17:47:11 CET 2011 on sn-devel-104
Günther Deschner [Wed, 16 Mar 2011 15:41:28 +0000 (16:41 +0100)]
s4-smbtorture: use torture_fail and _assert in torture_samba3_rpc_getusername().
Guenther
Günther Deschner [Wed, 16 Mar 2011 15:32:09 +0000 (16:32 +0100)]
s4-smbtorture: remove explicit mem_ctx from torture_samba3_rpc_getusername().
Guenther
Günther Deschner [Thu, 24 Feb 2011 23:11:14 +0000 (00:11 +0100)]
s3-packet: only include packet.h where needed.
Guenther
Günther Deschner [Thu, 24 Feb 2011 22:51:28 +0000 (23:51 +0100)]
s3-interfaces: only include interfaces.h where needed.
Guenther
Günther Deschner [Thu, 24 Feb 2011 21:58:08 +0000 (22:58 +0100)]
s3-msdfs: avoid global inclusion of msdfs.h.
Guenther
Günther Deschner [Wed, 16 Mar 2011 15:20:58 +0000 (16:20 +0100)]
s4-smbtorture: use torture_assert in samr large-dc test.
Guenther
David Disseldorp [Wed, 9 Mar 2011 14:18:22 +0000 (15:18 +0100)]
s3-printing: fix memory leak in print_cups.c
As found by valgrind, tmp_pcap_cache is not freed following printer list
tdb update.
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104
David Disseldorp [Wed, 9 Mar 2011 13:05:39 +0000 (14:05 +0100)]
s3-printing: remove duplicate cups response processing code
There is currently a lot of duplicate code included for processing
responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This
change splits this code into a separate function.
Signed-off-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Tue, 8 Mar 2011 15:36:03 +0000 (16:36 +0100)]
s3-printing: use printcap IDL for IPC
Use printcap IDL for marshalling and unmarshalling messages between cups
child and parent smbd processes. This simplifies the IPC and ensures
the parent is notified of cups errors encountered by the child.
https://bugzilla.samba.org/show_bug.cgi?id=7994
Signed-off-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Mon, 7 Mar 2011 14:32:02 +0000 (15:32 +0100)]
idl: define printcap IPC message format
Signed-off-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 16 Mar 2011 14:00:57 +0000 (15:00 +0100)]
s4-smbtorture: use torture_fail and _assert macros in torture_netlogon_samba3().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 15:51:12 CET 2011 on sn-devel-104
Günther Deschner [Wed, 16 Mar 2011 13:56:16 +0000 (14:56 +0100)]
s4-smbtorture: remove explicit mem_ctx from torture_netlogon_samba3().
Guenther
Günther Deschner [Wed, 16 Mar 2011 13:52:51 +0000 (14:52 +0100)]
s4-smbtorture: use torture_fail and _skip in raw.write test.
Guenther
Günther Deschner [Wed, 16 Mar 2011 13:51:30 +0000 (14:51 +0100)]
s4-smbtorture: remove duplicate if branch in raw.write test.
Guenther
Günther Deschner [Wed, 16 Mar 2011 12:27:38 +0000 (13:27 +0100)]
s4-smbtorture: use torture_fail/-assert api in torture_samba3_hide().
Guenther
Günther Deschner [Thu, 24 Feb 2011 10:56:08 +0000 (11:56 +0100)]
s3-build: stop including ldap and lber headers everywhere in the code.
Instead use new header smb_ldap.h where all LDAP API related things are handled,
while smbldap.h only deals with our smbldap_X() API.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104
Günther Deschner [Wed, 2 Mar 2011 13:03:30 +0000 (14:03 +0100)]
s3-includes: avoid global include of gssapi headers.
Guenther
Günther Deschner [Wed, 2 Mar 2011 13:00:23 +0000 (14:00 +0100)]
s3-libsmb: move smb encryption structs into own header.
Guenther
Günther Deschner [Thu, 24 Feb 2011 09:47:16 +0000 (10:47 +0100)]
libcli/security: move display_sec headers to own header file and add to
security.h grouping header.
Guenther
Stefan Metzmacher [Mon, 14 Mar 2011 07:37:31 +0000 (08:37 +0100)]
s4:ldb: don't install .pc files when building a private library
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Mar 16 09:58:22 CET 2011 on sn-devel-104
Andrew Tridgell [Wed, 16 Mar 2011 06:42:24 +0000 (17:42 +1100)]
headers: cope with non-system popt in test_headers
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar 16 09:09:40 CET 2011 on sn-devel-104
Andrew Tridgell [Wed, 16 Mar 2011 06:42:02 +0000 (17:42 +1100)]
headers: include Python.h first to avoid warnings
Volker Lendecke [Wed, 16 Mar 2011 06:31:48 +0000 (07:31 +0100)]
s3: Fix a cut&paste error in pdb_ads_connect
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 15 Mar 2011 08:30:22 +0000 (09:30 +0100)]
s3: Use jenkins hash for str_checksum, fix bug 8010
From the bugreport:
I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit
number, almost consecutive (photos from camera for one day).
Current implementation gives about 30 different checksums for this set of
files.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104
Andrew Tridgell [Tue, 15 Mar 2011 21:47:11 +0000 (08:47 +1100)]
libcli: openchange doesn't need these headers any more
thanks to Simo for pointing this out
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar 16 00:25:10 CET 2011 on sn-devel-104
Günther Deschner [Tue, 15 Mar 2011 21:51:58 +0000 (22:51 +0100)]
s3-build: try to silence annoying "Ignoring invalid value 'vlp' for parameter 'printing'"
warning on the buildfarm.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104
Günther Deschner [Tue, 15 Mar 2011 16:40:39 +0000 (17:40 +0100)]
s4-rap: remove last iconv_convenience traces from rap client and test code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 22:01:51 CET 2011 on sn-devel-104
Günther Deschner [Tue, 15 Mar 2011 16:28:51 +0000 (17:28 +0100)]
s4-rap: decouple rap client code from torture binary, add new LIBCLI_RAP subsystem.
Guenther
Günther Deschner [Tue, 15 Mar 2011 15:35:58 +0000 (16:35 +0100)]
s4-smbtorture: check for username and computername presence in rap_netsessionenum test.
Guenther
Günther Deschner [Thu, 24 Feb 2011 09:46:55 +0000 (10:46 +0100)]
s3-libsmb: only include rap client when needed.
Guenther
Günther Deschner [Tue, 15 Mar 2011 10:32:03 +0000 (11:32 +0100)]
s3-build: share smbtorture4 build rules with s3-waf build.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 15 Mar 2011 10:19:57 +0000 (11:19 +0100)]
libwbclient: CID 2199 -- NULL pointer return
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 15 12:08:48 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 15 Mar 2011 10:09:26 +0000 (11:09 +0100)]
s3: Fix Coverity ID 2278: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 10:08:12 +0000 (11:08 +0100)]
s3: Fix Coverity ID 2279: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 10:06:49 +0000 (11:06 +0100)]
s3: Fix Coverity ID 2280: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
git.samba.org / samba.git / log